Skip to content

Feature/allocation model get information tests #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature/allocation model get information tests #707

wants to merge 1 commit into from

Conversation

Eric-Butcher
Copy link
Contributor

No description provided.

@Eric-Butcher Eric-Butcher mentioned this pull request Jun 25, 2025
Draft
@Eric-Butcher Eric-Butcher marked this pull request as draft June 26, 2025 16:36
@Eric-Butcher Eric-Butcher force-pushed the feature/allocation-model-get-information-tests branch from b427b6b to 5e8a5ae Compare June 26, 2025 16:40
@Eric-Butcher
Copy link
Contributor Author

Eric-Butcher commented Jun 26, 2025 •
edited
Loading

The test cases where the ALLOCATION_ATTRIBUTE_VIEW_LIST are relevant just look a bit weird. See the case for test_attributes_with_names_in_view_list_included_in_information. Looking at the output and the function I am wondering if this is actually the behavior that is desired for get_information. I left some code commented out that will print the actual HTML being generated to a file so it can be more easily viewed but it seems kind of strange.

Also it seems like get_information would benefit from having its querysets having an explicit ordering applied. The default ordering for a queryset is database dependent so this might cause inconsistent behavior and have the current tests be inaccurate in some instances.

@Eric-Butcher Eric-Butcher force-pushed the feature/allocation-model-get-information-tests branch from 5e8a5ae to 82c8445 Compare June 30, 2025 14:45
@Eric-Butcher Eric-Butcher marked this pull request as ready for review June 30, 2025 14:45
@aebruno aebruno requested a review from ANekhai July 2, 2025 15:09
@Eric-Butcher
Test cases for the Allocation model get_information property.
f8fddb7 
Signed-off-by: Eric Butcher <107886303+Eric-Butcher@users.noreply.github.com>
@Eric-Butcher Eric-Butcher force-pushed the feature/allocation-model-get-information-tests branch from 82c8445 to f8fddb7 Compare July 3, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANekhai ANekhai Awaiting requested review from ANekhai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Eric-Butcher