Add an Allocation Attribute Edit Page #675
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecilialau6776
force-pushed
the
edit_alloc_attrs_3.12
branch
from
35975d0 to
426cfc5
Compare
|
@aebruno, I just wanted to ask if this was on the radar. |
|
@cecilialau6776 Sorry for the delay. Can you rebase this PR to main then we can review. Looks good otherwise, Thanks! |
cecilialau6776
force-pushed
the
edit_alloc_attrs_3.12
branch
2 times, most recently
from
b663cf4 to
670e89d
Compare
|
Rebased and added tests! |
cecilialau6776
force-pushed
the
edit_alloc_attrs_3.12
branch
from
c32996d to
b1570a0
Compare
|
@cecilialau6776 Thanks! Can you squash to a single commit and force push. |
cecilialau6776
force-pushed
the
edit_alloc_attrs_3.12
branch
from
b1570a0 to
917448a
Compare
Squashed commits: add allocation edit page add indicator for changed allocation attributes add allocation attribute change signals escape js for validation string fix errors and formatting add tests Signed-off-by: Cecilia Lau <cecilialau6776@gmail.com>
cecilialau6776
force-pushed
the
edit_alloc_attrs_3.12
branch
from
848b1f5 to
fac0e0c
Compare
|
@aebruno Yup! Squahsed and also rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a page that allows admins to edit allocation attributes and a button on the Allocation Detail page to access this page, which would close #672.
This PR also adds a signal for allocation attribute changes, which is sent when Allocation Change Requests are approved and through this page, which should [help] close #293.