-
Notifications
You must be signed in to change notification settings - Fork 560
show contract webhooks as deprecated #7612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 07-11-add_insight_filter_selection_to_webhook_creation_and_update
Are you sure you want to change the base?
show contract webhooks as deprecated #7612
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 07-11-add_insight_filter_selection_to_webhook_creation_and_update #7612 +/- ##
==================================================================================================
Coverage 56.44% 56.44%
==================================================================================================
Files 906 906
Lines 58126 58126
Branches 4228 4228
==================================================================================================
Hits 32811 32811
Misses 25205 25205
Partials 110 110
🚀 New features to boost your workflow:
|
size-limit report 📦
|
cfe1262
to
0f194e7
Compare
ab2a368
to
8c19216
Compare
|
|
8c19216
to
c1bfaeb
Compare
0f194e7
to
2d862e5
Compare
c1bfaeb
to
f70521d
Compare
2d862e5
to
a5f6f20
Compare
f70521d
to
d32a829
Compare
a5f6f20
to
2d4da17
Compare
d32a829
to
2c09e36
Compare
2d4da17
to
1e714ab
Compare
[Dashboard] Feature: Deprecate legacy contract webhooks
NB! This should be merged only once the new webhooks UI is available to all users, not just thirdweb
Notes for the reviewer
This PR updates the contract webhooks UI to mark them as deprecated, removing the ability to create new contract webhooks and test existing ones. Users are now directed to use the new unified webhooks system.
Key changes:
How to test
Navigate to the contract webhooks page for a project to verify:
PR-Codex overview
This PR primarily refactors the
ContractsWebhooksPageContent
andContractsWebhooksTable
components to improve code clarity and update the handling of webhooks, including deprecation notices and UI adjustments.Detailed summary
supportedChainIds
to_supportedChainIds
,client
to_client
.ContractsWebhooksTable
props to acceptproject
instead of multiple parameters.CreateContractWebhookButton
from the sidebar.