Skip to content

show contract webhooks as deprecated #7612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 07-11-add_insight_filter_selection_to_webhook_creation_and_update
Choose a base branch
from

Conversation

iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Jul 14, 2025

[Dashboard] Feature: Deprecate legacy contract webhooks

NB! This should be merged only once the new webhooks UI is available to all users, not just thirdweb

Notes for the reviewer

This PR updates the contract webhooks UI to mark them as deprecated, removing the ability to create new contract webhooks and test existing ones. Users are now directed to use the new unified webhooks system.

Key changes:

  • Added a deprecation notice banner with a link to the new webhooks section
  • Removed the "Create Webhook" and "Test Webhook" buttons
  • Updated the status badge to show "Deprecated" instead of "Active/Suspended"
  • Simplified the component props by passing the entire project object
  • Updated styling to make the UI appear more visually deprecated

How to test

Navigate to the contract webhooks page for a project to verify:

  1. The deprecation banner appears with a link to the new webhooks section
  2. Existing webhooks are displayed but can only be deleted, not tested
  3. The "Create Webhook" button is removed
  4. All webhooks show as "Deprecated" in the status column

PR-Codex overview

This PR primarily refactors the ContractsWebhooksPageContent and ContractsWebhooksTable components to improve code clarity and update the handling of webhooks, including deprecation notices and UI adjustments.

Detailed summary

  • Renamed variables: supportedChainIds to _supportedChainIds, client to _client.
  • Updated ContractsWebhooksTable props to accept project instead of multiple parameters.
  • Removed the CreateContractWebhookButton from the sidebar.
  • Added a deprecation notice for legacy webhooks.
  • Changed button functionality for deleting webhooks.
  • Updated UI elements to enhance readability and user experience.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 11:04pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 14, 2025 11:04pm
nebula ⬜️ Skipped (Inspect) Jul 14, 2025 11:04pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 14, 2025 11:04pm
wallet-ui ⬜️ Skipped (Inspect) Jul 14, 2025 11:04pm

@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 21:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 21:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 21:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 14, 2025 21:40 Inactive
Copy link
Contributor

coderabbitai bot commented Jul 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor Author

iuwqyir commented Jul 14, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir requested review from arcoraven, MananTank and a team July 14, 2025 21:41
@iuwqyir iuwqyir marked this pull request as ready for review July 14, 2025 21:41
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (2c09e36) to head (1e714ab).

Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           07-11-add_insight_filter_selection_to_webhook_creation_and_update    #7612   +/-   ##
==================================================================================================
  Coverage                                                              56.44%   56.44%           
==================================================================================================
  Files                                                                    906      906           
  Lines                                                                  58126    58126           
  Branches                                                                4228     4228           
==================================================================================================
  Hits                                                                   32811    32811           
  Misses                                                                 25205    25205           
  Partials                                                                 110      110           
Flag Coverage Δ
packages 56.44% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.25 KB (0%) 1.3 s (0%) 307 ms (+147.91% 🔺) 1.6 s
thirdweb (cjs) 353.31 KB (0%) 7.1 s (0%) 983 ms (+18.33% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 124 ms (+1397.45% 🔺) 238 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 57 ms (+1542.74% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 136 ms (+748.94% 🔺) 528 ms

@iuwqyir iuwqyir force-pushed the 07-15-show_contract_webhooks_as_deprecated branch from cfe1262 to 0f194e7 Compare July 14, 2025 21:50
@iuwqyir iuwqyir force-pushed the 07-11-add_insight_filter_selection_to_webhook_creation_and_update branch from ab2a368 to 8c19216 Compare July 14, 2025 21:50
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: 1e714ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 14, 2025 21:50 Inactive
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: 0f194e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 21:50 Inactive
@iuwqyir iuwqyir force-pushed the 07-11-add_insight_filter_selection_to_webhook_creation_and_update branch from 8c19216 to c1bfaeb Compare July 14, 2025 21:55
@iuwqyir iuwqyir force-pushed the 07-15-show_contract_webhooks_as_deprecated branch from 0f194e7 to 2d862e5 Compare July 14, 2025 21:55
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 14, 2025 21:55 Inactive
@iuwqyir iuwqyir force-pushed the 07-11-add_insight_filter_selection_to_webhook_creation_and_update branch from c1bfaeb to f70521d Compare July 14, 2025 21:56
@iuwqyir iuwqyir force-pushed the 07-15-show_contract_webhooks_as_deprecated branch from 2d862e5 to a5f6f20 Compare July 14, 2025 21:56
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 14, 2025 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 21:56 Inactive
@iuwqyir iuwqyir force-pushed the 07-11-add_insight_filter_selection_to_webhook_creation_and_update branch from f70521d to d32a829 Compare July 14, 2025 22:49
@iuwqyir iuwqyir force-pushed the 07-15-show_contract_webhooks_as_deprecated branch from a5f6f20 to 2d4da17 Compare July 14, 2025 22:49
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 22:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 14, 2025 22:49 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 22:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 22:49 Inactive
@iuwqyir iuwqyir force-pushed the 07-11-add_insight_filter_selection_to_webhook_creation_and_update branch from d32a829 to 2c09e36 Compare July 14, 2025 22:56
@iuwqyir iuwqyir force-pushed the 07-15-show_contract_webhooks_as_deprecated branch from 2d4da17 to 1e714ab Compare July 14, 2025 22:56
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 14, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 22:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant