Skip to content

fix playground payments widget #7607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix playground payments widget #7607

merged 1 commit into from
Jul 14, 2025

Conversation

Yash094
Copy link
Member

@Yash094 Yash094 commented Jul 14, 2025


PR-Codex overview

This PR focuses on updating the property name for the token address in the CodeGen component within the playground-web application, ensuring consistency in the code.

Detailed summary

  • Changed the property from token to tokenAddress in the CodeGen component.
  • Maintained existing conditions and formatting for other properties like seller, title, image, description, paymentMethods, and currency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor
    • Updated the generated code output to use the prop name tokenAddress instead of token when displaying the token address in the code example. This change does not affect any other visible functionality.

Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: 6c8a7cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 6:02pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 14, 2025 6:02pm
nebula ⬜️ Skipped (Inspect) Jul 14, 2025 6:02pm
thirdweb-www ⬜️ Skipped (Inspect) Jul 14, 2025 6:02pm
wallet-ui ⬜️ Skipped (Inspect) Jul 14, 2025 6:02pm

Copy link
Contributor

coderabbitai bot commented Jul 14, 2025

Walkthrough

The code generation logic in the CodeGen.tsx file was updated to rename the token prop to tokenAddress in the generated JSX for the Example component when options.payOptions.buyTokenAddress is present. No other logic or exported entities were changed.

Changes

File(s) Change Summary
apps/playground-web/src/app/connect/pay/components/CodeGen.tsx Updated code generation to use tokenAddress instead of token for the relevant prop in JSX.

Sequence Diagram(s)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9319901 and 6c8a7cf.

📒 Files selected for processing (1)
  • apps/playground-web/src/app/connect/pay/components/CodeGen.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/playground-web/src/app/connect/pay/components/CodeGen.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

graphite-app bot commented Jul 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Jul 14, 2025
@Yash094 Yash094 marked this pull request as ready for review July 14, 2025 11:34
@Yash094 Yash094 requested review from a team as code owners July 14, 2025 11:34
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (4f02f6e) to head (6c8a7cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7607   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files         906      906           
  Lines       58115    58115           
  Branches     4226     4226           
=======================================
  Hits        32810    32810           
  Misses      25195    25195           
  Partials      110      110           
Flag Coverage Δ
packages 56.45% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.25 KB (0%) 1.3 s (0%) 296 ms (+138.52% 🔺) 1.6 s
thirdweb (cjs) 353.31 KB (0%) 7.1 s (0%) 958 ms (+3.64% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 127 ms (+1505.47% 🔺) 241 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 26 ms (+616.3% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 109 ms (+640.18% 🔺) 501 ms

@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Jul 14, 2025
Copy link
Member

MananTank commented Jul 14, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `CodeGen` component in the `playground-web` application by renaming a prop for consistency and clarity.

### Detailed summary
- Changed the prop name from `token` to `tokenAddress` in the `CodeGen` component.
- Maintained existing conditional rendering for other props such as `seller`, `title`, `image`, `description`, `paymentMethods`, and `currency`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Refactor**
  * Updated the generated code output to use the prop name `tokenAddress` instead of `token` when displaying the token address in the code example. This change does not affect any other visible functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the yash/fix-paywidget-code branch from 9319901 to 6c8a7cf Compare July 14, 2025 18:02
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 14, 2025 18:02 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 14, 2025 18:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 14, 2025 18:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www July 14, 2025 18:02 Inactive
@graphite-app graphite-app bot merged commit 6c8a7cf into main Jul 14, 2025
23 checks passed
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jul 14, 2025
@graphite-app graphite-app bot deleted the yash/fix-paywidget-code branch July 14, 2025 18:05
@vercel vercel bot temporarily deployed to Production – thirdweb-www July 14, 2025 18:05 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 July 14, 2025 18:05 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 14, 2025 18:05 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui July 14, 2025 18:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants