-
Notifications
You must be signed in to change notification settings - Fork 560
Add next button to inner page footers #7605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add next button to inner page footers #7605
Conversation
Co-authored-by: joaquim.verges <joaquim.verges@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughA "Next Page" navigation feature was introduced to the document portal. This includes a utility to find the next page from sidebar links, a button component for navigation, and integration into the page footer. The layout and footer components were updated to support and display this new navigation button. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DocLayout
participant PageFooter
participant AutoNextPageButton
participant getNextPageFromSidebar
participant NextPageButton
User->>DocLayout: Navigates to a document page
DocLayout->>PageFooter: Renders with sidebarLinks
PageFooter->>AutoNextPageButton: Renders with sidebarLinks
AutoNextPageButton->>getNextPageFromSidebar: Find next page (sidebarLinks, currentPath)
getNextPageFromSidebar-->>AutoNextPageButton: Returns next page info or null
alt Next page exists
AutoNextPageButton->>NextPageButton: Render with next page href and name
NextPageButton-->>User: User can click to navigate to next page
else No next page
AutoNextPageButton-->>PageFooter: Renders nothing
end
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}Instructions used from: Sources:
🧠 Learnings (6)📓 Common learnings
apps/portal/src/components/Layouts/DocLayout.tsx (12)
apps/portal/src/components/Document/PageFooter.tsx (10)
apps/portal/src/components/Document/AutoNextPageButton.tsx (11)
apps/portal/src/components/Document/NextPageButton.tsx (11)
apps/portal/src/components/Document/utils/getNextPageFromSidebar.ts (7)
🧬 Code Graph Analysis (1)apps/portal/src/components/Layouts/DocLayout.tsx (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (12)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7605 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 906 906
Lines 58115 58115
Branches 4226 4226
=======================================
Hits 32810 32810
Misses 25195 25195
Partials 110 110
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Slack Thread
Summary by CodeRabbit