[SDK] Fix: Adds BuyWidget fallback when native isn't supported #7601

gregfromstl · 2025-07-11T23:09:41Z

PR-Codex overview

This PR focuses on improving error handling and default values in the BuyWidget component and enhancing the fetchTokensFromApi function by allowing a fallback for the bridge URL.

Detailed summary

In BuyWidget.tsx:
- Added error handling for unsupported tokens.
- Returned a default object for unsupported tokens.
In useTokensData.ts:
- Set a fallback for domain in fetchTokensFromApi.
- Adjusted URL creation to handle localhost correctly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Improved error handling in the BuyWidget to better manage unsupported native tokens, ensuring the UI displays appropriate feedback.
- Enhanced URL construction logic for token data fetching, providing better support for different environments, including local development.

linear · 2025-07-11T23:09:44Z

TOOL-5033 Add BuyWidget Fallback when Native Isn't Supported

changeset-bot · 2025-07-11T23:09:45Z

⚠️ No Changeset found

Latest commit: 99cea8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-07-11T23:09:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 13, 2025 9:43pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jul 13, 2025 9:43pm
nebula	⬜️ Skipped (Inspect)	Jul 13, 2025 9:43pm
thirdweb-www	⬜️ Skipped (Inspect)	Jul 13, 2025 9:43pm
wallet-ui	⬜️ Skipped (Inspect)	Jul 13, 2025 9:43pm

coderabbitai · 2025-07-11T23:09:48Z

Walkthrough

The changes update environment variable handling and error management in two areas: URL construction in a hook now defaults to a specific domain and protocol logic, while the BuyWidget component introduces explicit error catching and fallback for unsupported native tokens. No exported or public API signatures were altered.

Changes

File(s)	Change Summary
apps/playground-web/src/hooks/useTokensData.ts	Updated domain defaulting to "bridge.thirdweb.com" and protocol selection based on domain value.
packages/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx	Added error catching for unsupported native tokens and fallback object for UI handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BuyWidget
    participant getToken

    User->>BuyWidget: Initiate bridgeDataQuery
    BuyWidget->>getToken: Request native token info
    alt Token supported
        getToken-->>BuyWidget: Return token info
        BuyWidget-->>User: Proceed with token data
    else Token not supported
        getToken-->>BuyWidget: Throw "not supported" error
        BuyWidget-->>User: Return unsupported token object
    else Other error
        getToken-->>BuyWidget: Throw error
        BuyWidget-->>User: Propagate error
    end

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b58e5c and 99cea8b.

📒 Files selected for processing (1)

apps/playground-web/src/hooks/useTokensData.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/playground-web/src/hooks/useTokensData.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Size
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Unit Tests
GitHub Check: Build Packages
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graphite-app · 2025-07-11T23:09:49Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

gregfromstl · 2025-07-11T23:10:50Z

Merge activity

Jul 11, 11:10 PM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 11, 11:11 PM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

github-actions · 2025-07-11T23:15:19Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	63.25 KB (0%)	1.3 s (0%)	356 ms (+120.97% 🔺)	1.7 s
thirdweb (cjs)	353.31 KB (0%)	7.1 s (0%)	1.3 s (+5.92% 🔺)	8.4 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	112 ms (+764.63% 🔺)	226 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	61 ms (+1947.73% 🔺)	71 ms
thirdweb/react (minimal + tree-shaking)	19.59 KB (0%)	392 ms (0%)	100 ms (+223.14% 🔺)	492 ms

codecov · 2025-07-11T23:15:56Z

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (592bf6f) to head (99cea8b).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...ges/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx	0.00%	12 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7601      +/-   ##
==========================================
- Coverage   56.45%   56.44%   -0.01%     
==========================================
  Files         906      906              
  Lines       58115    58126      +11     
  Branches     4226     4228       +2     
==========================================
+ Hits        32810    32811       +1     
- Misses      25195    25205      +10     
  Partials      110      110

Flag	Coverage Δ
packages	`56.44% <0.00%> (-0.01%)`	⬇️

Files with missing lines	Coverage Δ
...ges/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx	`9.33% <0.00%> (-0.74%)`	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix: adds fallback to BuyWidget when native ETH isn't supported

c82c978

gregfromstl requested review from a team as code owners July 11, 2025 23:09

github-actions bot assigned gregfromstl Jul 11, 2025

github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Jul 11, 2025

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jul 11, 2025

gregfromstl requested a review from joaquim-verges July 11, 2025 23:10

vercel bot deployed to Preview – wallet-ui July 11, 2025 23:11 View deployment

vercel bot deployed to Preview – nebula July 11, 2025 23:11 View deployment

vercel bot deployed to Preview – thirdweb_playground July 11, 2025 23:12 View deployment

vercel bot deployed to Preview – thirdweb-www July 11, 2025 23:18 View deployment

vercel bot deployed to Preview – docs-v2 July 11, 2025 23:19 View deployment

joaquim-verges approved these changes Jul 12, 2025

View reviewed changes

fix: localhost ub domains

99cea8b

gregfromstl force-pushed the greg/tool-5033-add-buywidget-fallback-when-native-isnt-supported branch from 7b58e5c to 99cea8b Compare July 13, 2025 21:40

vercel bot temporarily deployed to Preview – wallet-ui July 13, 2025 21:40 Inactive

vercel bot temporarily deployed to Preview – nebula July 13, 2025 21:40 Inactive

vercel bot temporarily deployed to Preview – docs-v2 July 13, 2025 21:40 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www July 13, 2025 21:40 Inactive

vercel bot deployed to Preview – thirdweb_playground July 13, 2025 21:43 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix: Adds BuyWidget fallback when native isn't supported #7601

[SDK] Fix: Adds BuyWidget fallback when native isn't supported #7601

gregfromstl commented Jul 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Jul 11, 2025

Uh oh!

changeset-bot bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 11, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

graphite-app bot commented Jul 11, 2025

Uh oh!

gregfromstl commented Jul 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

[SDK] Fix: Adds BuyWidget fallback when native isn't supported #7601

Are you sure you want to change the base?

[SDK] Fix: Adds BuyWidget fallback when native isn't supported #7601

Conversation

gregfromstl commented Jul 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

linear bot commented Jul 11, 2025

Uh oh!

changeset-bot bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

graphite-app bot commented Jul 11, 2025

How to use the Graphite Merge Queue

Uh oh!

gregfromstl commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

github-actions bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

gregfromstl commented Jul 11, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jul 11, 2025 •

edited

Loading

vercel bot commented Jul 11, 2025 •

edited

Loading

coderabbitai bot commented Jul 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

gregfromstl commented Jul 11, 2025 •

edited

Loading

github-actions bot commented Jul 11, 2025 •

edited

Loading

codecov bot commented Jul 11, 2025 •

edited

Loading