Skip to content

Deprecate modular contracts from Explore #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Jul 2, 2025


PR-Codex overview

This PR focuses on deprecating the modular-contracts feature across the codebase, removing references to pre-built modular contracts, and updating documentation to guide users towards standard contracts.

Detailed summary

  • Marked modular-contracts as deprecated in data.ts.
  • Removed references to pre-built modular contracts in the sidebar.
  • Updated documentation to inform users of the deprecation and recommend standard contracts for new deployments.
  • Added warning callouts in documentation for pre-built modular token and NFT collection contracts.

The following files were skipped due to too many changes: apps/portal/redirects.mjs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Deprecated modular contracts are now hidden from the Explore section in the dashboard.
    • Updated sidebar navigation to remove links to pre-built modular contracts, ensuring only standard contracts are visible.
    • Added redirects from deprecated modular contract URLs to a consolidated overview page.
  • Documentation

    • Added deprecation warnings to modular contract documentation, advising users to use standard contracts for new deployments. Existing documentation remains accessible for reference.

@saminacodes saminacodes requested review from a team as code owners July 2, 2025 22:10
Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: 5c798c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 0:01am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 11, 2025 0:01am
nebula ⬜️ Skipped (Inspect) Jul 11, 2025 0:01am
thirdweb_playground ⬜️ Skipped (Inspect) Jul 11, 2025 0:01am
wallet-ui ⬜️ Skipped (Inspect) Jul 11, 2025 0:01am

Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

Walkthrough

The updates deprecate the "Pre-built Modular" contracts from the Explore UI and documentation. The relevant category is hidden in the dashboard, deprecation warnings are added to related documentation pages, sidebar navigation links to modular contracts are removed, and redirects for deprecated modular contract URLs are added. No functional or control flow changes are introduced.

Changes

File(s) Change Summary
apps/dashboard/src/app/(app)/(dashboard)/explore/data.ts Added showInExplore: false to MODULAR_CONTRACTS and updated comments to mark as deprecated.
apps/portal/src/app/contracts/explore/pre-built-modular/nft-collection/page.mdx
apps/portal/src/app/contracts/explore/pre-built-modular/token/page.mdx
Added "Deprecated" warning callouts explaining modular contracts are no longer available in Explore.
apps/portal/src/app/contracts/sidebar.tsx Removed sidebar links for modular contracts in Explore and Build sections.
apps/portal/redirects.mjs Added redirects from deprecated modular contract URLs to consolidated overview page.

Sequence Diagram(s)

No sequence diagram is generated as the changes are limited to configuration, documentation, UI visibility, and redirects without affecting control flow or feature logic.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7483db and be9dade.

📒 Files selected for processing (1)
  • apps/portal/src/app/contracts/sidebar.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/src/app/contracts/sidebar.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

graphite-app bot commented Jul 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels Jul 2, 2025
@saminacodes saminacodes requested a review from MananTank July 2, 2025 22:10
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.46%. Comparing base (ffb7b64) to head (5c798c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7515   +/-   ##
=======================================
  Coverage   56.46%   56.46%           
=======================================
  Files         906      906           
  Lines       58072    58072           
  Branches     4222     4222           
=======================================
  Hits        32790    32790           
  Misses      25174    25174           
  Partials      108      108           
Flag Coverage Δ
packages 56.46% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.25 KB (0%) 1.3 s (0%) 722 ms (+134.4% 🔺) 2 s
thirdweb (cjs) 353.31 KB (0%) 7.1 s (0%) 2.7 s (+12.37% 🔺) 9.7 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 211 ms (+1162.67% 🔺) 325 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 99 ms (+1621.87% 🔺) 109 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 266 ms (+391.12% 🔺) 658 ms

@vercel vercel bot temporarily deployed to Preview – nebula July 2, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www July 2, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 10, 2025 19:08 Inactive
joaquim-verges
joaquim-verges previously approved these changes Jul 10, 2025
@saminacodes saminacodes added the merge-queue Adds the pull request to Graphite's merge queue. label Jul 10, 2025
Copy link
Member Author

Merge activity

  • Jul 10, 7:34 PM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@joaquim-verges joaquim-verges dismissed their stale review July 10, 2025 19:56

redirects seem wrong

@vercel vercel bot temporarily deployed to Preview – nebula July 10, 2025 23:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 10, 2025 23:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 10, 2025 23:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 10, 2025 23:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants