retry on signature failures

[joaquim-verges]

Summary by CodeRabbit

• New Features

  • Introduced a unified retry mechanism for handling errors, allowing automatic retries for certain failures with configurable limits and delays.

• Refactor

  • Centralized and streamlined error retry logic for a more consistent and maintainable experience.

End-users may now benefit from improved reliability in error-prone operations, as transient issues are automatically retried before reporting a failure.

[coderabbitai]

Walkthrough

A unified retry handling mechanism is introduced in the Eip7702SendHandler::process method by centralizing error-to-retry logic into a new helper function, handle_with_retry. This function manages job retries with configurable limits and delays, replacing scattered retry logic in error mapping throughout the method.

Changes

File(s)	Change Summary
executors/src/eip7702_executor/send.rs	Introduced handle_with_retry helper function and RetryConfig struct; replaced direct error mapping with unified retry logic; updated imports to support new retry mechanism.

Sequence Diagram(s)

sequenceDiagram
    participant Handler as Eip7702SendHandler
    participant Service as ChainService / Bundler / Signer
    participant Retry as handle_with_retry

    Handler->>Service: Perform operation (e.g., get_chain_service, sign_typed_data)
    Service-->>Handler: Result or Error
    alt Error occurs
        Handler->>Retry: handle_with_retry(attempts, error_factory, config)
        alt Attempts < max_attempts
            Retry-->>Handler: JobError::Requeue (with delay)
        else Attempts >= max_attempts
            Retry-->>Handler: JobError::Fail (permanent)
        end
    else Success
        Handler-->>Handler: Continue processing
    end

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)

Updating crates.io index
Updating git repository `ssh://git@github.com/thirdweb-dev/vault.git`

error: failed to get vault-sdk as a dependency of package engine-aa-core v0.1.0 (/aa-core)

Caused by:
failed to load source for dependency vault-sdk

Caused by:
Unable to update ssh://git@github.com/thirdweb-dev/vault.git?branch=pb%2Fupdate-alloy#b0a72f93

Caused by:
failed to create directory /usr/local/git/db/vault-02bb070e2aa0045e

Caused by:
Permission denied (os error 13)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6be3247 and 81da1bd.

📒 Files selected for processing (1)

• executors/src/eip7702_executor/send.rs (7 hunks)

🔇 Additional comments (8)

executors/src/eip7702_executor/send.rs (8)

19-19: LGTM! Import additions are correct.

The added imports for Duration and RequeuePosition are necessary for the retry functionality implementation.

Also applies to: 24-24

---

40-53: LGTM! RetryConfig design is well-structured.

The default configuration (3 attempts, 3-second delay) provides a reasonable balance for handling transient failures without overwhelming external services.

---

209-218: LGTM! Chain service retry implementation is appropriate.

Adding retry logic for chain service errors is beneficial since these can fail due to transient network issues or rate limiting.

---

269-278: LGTM! Signing retry logic is well-implemented.

The retry mechanism for signing operations is appropriate since signing services can experience transient failures. The error handling preserves the original error details for debugging.

Also applies to: 308-317

---

283-292: LGTM! Delegation check retry logic is sound.

Adding retry logic for the delegation check is appropriate since it involves network calls that can fail transiently.

---

338-346: LGTM! Bundler call retry implementation is crucial.

The retry mechanism for bundler calls is essential since these are critical network operations that can fail due to various transient issues.

---

554-572: LGTM! Helper function is well-designed and efficient.

The generic design enables consistent retry behavior across different error types. The logic correctly handles the retry/fail decision based on attempt count, and the error factory closure pattern is efficient.

---

209-346: Excellent selective retry application strategy.

The decision to apply retry logic only to network/external service calls (chain service, signing, delegation check, bundler calls) while excluding local validation/serialization errors demonstrates thoughtful error categorization and prevents unnecessary retries of permanent failures.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.