Update to support EventBus7 #129
Open
+522
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do old Forge versions (1.21.1-1.21.5) use EB7? This could be a breaking change that I don't want to merge into KFF 6.x |
|
But, it also breaks support for MC 1.21.6-1.21.7 |
thedarkcolour
requested changes
Jul 13, 2025
There was a problem hiding this comment.
Why all of these random Gradle options? If these changes are just for your setup, please remove them from the PR
|
|
||
| min_mc_version = 1.20.6 | ||
| unsupported_mc_version = 1.22 | ||
|
|
||
| # KOTLIN FOR FORGE VERSION | ||
| kff_version=5.9.0 | ||
| kff_max_version=6.0.0 |
There was a problem hiding this comment.
This should be 7.0.0, not 6.1.0
| @@ -132,9 +133,9 @@ public object AutoKotlinEventBusSubscriber { | |||
|
|
|||
| private fun registerTo(any: Any, target: Mod.EventBusSubscriber.Bus, mod: KotlinModContainer) { | |||
| if (target == Mod.EventBusSubscriber.Bus.FORGE) { | |||
| target.bus().get().register(any) | |||
| target.bus().get()?.register(MethodHandles.lookup(), any) | |||
There was a problem hiding this comment.
Why is the bus supplier now nullable? Should this log an error if the bus is null?
There was a problem hiding this comment.
The compiler 2.2.0 won't let me go without !! or ?
There was a problem hiding this comment.
Please remove this change from the PR
|
Is it ok now? |
|
ok
…On Sun, Jul 13, 2025 at 6:39 AM thedarkcolour ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I'll review the KotlinModContainer class later, I'm suspicious of the
module reflection, but knowing LexForge, it's probably just how they
decided to do it...
------------------------------
On gradle.properties
<#129 (comment)>
:
Why all of these random Gradle options? If these changes are just for your
setup, please remove them from the PR
------------------------------
In gradle.properties
<#129 (comment)>
:
>
min_mc_version = 1.20.6
unsupported_mc_version = 1.22
# KOTLIN FOR FORGE VERSION
-kff_version=5.9.0
-kff_max_version=6.0.0
This should be 7.0.0, not 6.1.0
------------------------------
In
src/kfflang/forge/kotlin/thedarkcolour/kotlinforforge/AutoKotlinEventBusSubscriber.kt
<#129 (comment)>
:
> @@ -132,9 +133,9 @@ public object AutoKotlinEventBusSubscriber {
private fun registerTo(any: Any, target: Mod.EventBusSubscriber.Bus, mod: KotlinModContainer) {
if (target == Mod.EventBusSubscriber.Bus.FORGE) {
- target.bus().get().register(any)
+ target.bus().get()?.register(MethodHandles.lookup(), any)
Why is the bus supplier now nullable? Should this log an error if the bus
is null?
------------------------------
On
src/kfflang/forge/resources/META-INF/services/net.minecraftforge.forgespi.language.IModLanguageProvider
<#129 (comment)>
:
Please remove this change from the PR
—
Reply to this email directly, view it on GitHub
<#129 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BK6AZOOB5WOF5UYTEULFC733IHWK5AVCNFSM6AAAAACBL6TRCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJTHA4DCOJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated KotlinForForge to support MC 1.21.7 and the new EventBus7 introduced in Forge 57.x.
Mod containers now use BusGroup for event dispatching, keeping up with the Forge changes.