all: bump to latest prometheus #594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Jun 14, 2025
MichaHoffmann
force-pushed
the
mhoffmann/bump-prometheus
branch
6 times, most recently
from
2118540 to
99fb088
Compare
|
Fuzzing and tests fail because of: https://cloud-native.slack.com/archives/C01AUBA4PFE/p1749978859618789 We need to wait for:
Also: I think we need to revisit warnings somewhat, they feel a bit all over the place right now |
MichaHoffmann
force-pushed
the
mhoffmann/bump-prometheus
branch
from
99fb088 to
681bb54
Compare
MichaHoffmann
commented
Jun 15, 2025
| @@ -208,6 +281,7 @@ func (o *histogramOperator) loadSeries(ctx context.Context) error { | |||
| ) | |||
|
|
|||
| o.series = make([]labels.Labels, 0) | |||
| o.inputSeriesNames = make([]string, len(series)) | |||
There was a problem hiding this comment.
so this is kinda gross, but needed to pass the promql acceptance tests since the series name is part of the expected warning.
MichaHoffmann
force-pushed
the
mhoffmann/bump-prometheus
branch
3 times, most recently
from
ffaa592 to
d4e6dc2
Compare
Bump to latest prometheus and fix fallout. Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
MichaHoffmann
force-pushed
the
mhoffmann/bump-prometheus
branch
from
d4e6dc2 to
3030504
Compare
|
Could we run benchmarks like in #567? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to latest prometheus and fix fallout. Also made XFunctions always enabled.