feat: Issue 1193 support for tagging subnets by name #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidshard
changed the title
voidshard
force-pushed
the
1193/Support_for_tagging_subnets_by_name
branch
from
5da956a to
55a871b
Compare
voidshard
force-pushed
the
1193/Support_for_tagging_subnets_by_name
branch
from
55a871b to
9bd4853
Compare
voidshard
changed the title
voidshard
changed the title
voidshard
force-pushed
the
1193/Support_for_tagging_subnets_by_name
branch
from
152d025 to
9ae1a79
Compare
|
@antonbabenko @bryantbiggs please let me know your thoughts - we switched to using this module at work to define our VPCs but need a bit more flexibility to tag subnets appropriately for autodiscovery & configuration purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows one to add per-subnet tags, settable by subnet name.
Motivation and Context
Currently it is possible to set tags on all subnets, or all subnets of a given distinction (eg. public, private, ..) but it is not possible to set tags on a given subnet. This is the motivation behind this issue and the related MR. This MR adds the same support for each subnet type rather than just public & private.
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI added my own simple example. It includes cases where all, none and a subset of subnets have custom tags added by name.