-
Notifications
You must be signed in to change notification settings - Fork 6
Removed unused models #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Removed unused models #101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 90.69% 90.65% -0.04%
==========================================
Files 28 28
Lines 1794 1787 -7
Branches 172 172
==========================================
- Hits 1627 1620 -7
Misses 106 106
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please update the description to indicate this addresses an open issue. There is already an issue for removing the specific model numbers. |
Heyy @nfelt14 , I've updated the description, also Im new to open source, so let me know if there's any corrections left. |
I left a comment in the changed file. Once you address it, this PR should be good to go. |
Breaking API Changes
|
Test Results (macos)
tests/test_tm_data_types.py('/Users/runner/work/tm_data_types/tm_data_types/tests/test_tm_data_types.py', 549, 'Skipped: Skipping 1G test in GitHub Actions environment') |
Test Results (ubuntu)
tests/test_tm_data_types.py('/home/runner/work/tm_data_types/tm_data_types/tests/test_tm_data_types.py', 549, 'Skipped: Skipping 1G test in GitHub Actions environment') |
Test Results (windows)
tests\test_tm_data_types.py('D:\\a\\tm_data_types\\tm_data_types\\tests\\test_tm_data_types.py', 549, 'Skipped: Skipping 1G test in GitHub Actions environment') |
@Spiritedswordsman, unfortunately, your commits aren't signed. You will need to sign all of your previous commits before we can merge this PR. |
3cf966e
to
e01eb3b
Compare
e01eb3b
to
e15978b
Compare
Types of changes
What types of changes does your code introduce?
removed unused models from
instrument_series.py
, addressing the issue #99Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>