Skip to content

Removed unused models #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Spiritedswordsman
Copy link

@Spiritedswordsman Spiritedswordsman commented Jul 10, 2025

Types of changes

What types of changes does your code introduce?
removed unused models from instrument_series.py, addressing the issue #99

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (ffa156c) to head (3cf966e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   90.69%   90.65%   -0.04%     
==========================================
  Files          28       28              
  Lines        1794     1787       -7     
  Branches      172      172              
==========================================
- Hits         1627     1620       -7     
  Misses        106      106              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nfelt14
Copy link
Collaborator

nfelt14 commented Jul 10, 2025

Please update the description to indicate this addresses an open issue. There is already an issue for removing the specific model numbers.

@Spiritedswordsman
Copy link
Author

Heyy @nfelt14 , I've updated the description, also Im new to open source, so let me know if there's any corrections left.
Thank you 😇

@nfelt14
Copy link
Collaborator

nfelt14 commented Jul 10, 2025

Heyy @nfelt14 , I've updated the description, also Im new to open source, so let me know if there's any corrections left.
Thank you 😇

I left a comment in the changed file. Once you address it, this PR should be good to go.

Copy link

github-actions bot commented Jul 10, 2025

Breaking API Changes

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO64:
Public object was removed

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO64B:
Public object was removed

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO54:
Public object was removed

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO54B:
Public object was removed

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO44:
Public object was removed

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO44B:
Public object was removed

src/tm_data_types/helpers/instrument_series.py:0: InstrumentSeries.MSO24:
Public object was removed

Link to workflow run

Copy link

github-actions bot commented Jul 10, 2025

Test Results (macos)

path passed skipped subtotal
tests/test_tm_data_types.py 20 1 21
TOTAL 20 1 21
tests/test_tm_data_types.py
('/Users/runner/work/tm_data_types/tm_data_types/tests/test_tm_data_types.py', 549, 'Skipped: Skipping 1G test in GitHub Actions environment')

Link to workflow run

Copy link

github-actions bot commented Jul 10, 2025

Test Results (ubuntu)

path passed skipped subtotal
tests/test_tm_data_types.py 20 1 21
TOTAL 20 1 21
tests/test_tm_data_types.py
('/home/runner/work/tm_data_types/tm_data_types/tests/test_tm_data_types.py', 549, 'Skipped: Skipping 1G test in GitHub Actions environment')

Link to workflow run

Copy link

github-actions bot commented Jul 10, 2025

Test Results (windows)

path passed skipped subtotal
tests\test_tm_data_types.py 20 1 21
TOTAL 20 1 21
tests\test_tm_data_types.py
('D:\\a\\tm_data_types\\tm_data_types\\tests\\test_tm_data_types.py', 549, 'Skipped: Skipping 1G test in GitHub Actions environment')

Link to workflow run

@nfelt14
Copy link
Collaborator

nfelt14 commented Jul 10, 2025

@Spiritedswordsman, unfortunately, your commits aren't signed. You will need to sign all of your previous commits before we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants