Replace kzalloc with mempool to reduce memory fragmentation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jul 6, 2025
| @@ -7,6 +7,8 @@ | |||
| #include "http_parser.h" | |||
| #include "http_server.h" | |||
|
|
|||
| extern mempool_t *http_buf_pool; | |||
There was a problem hiding this comment.
Don't use extern here. Honor the header instead.
There was a problem hiding this comment.
The issue has been fixed. Thanks, professor.
There was a problem hiding this comment.
The issue has been fixed.
No, you didn't.
jserv
reviewed
Jul 6, 2025
main.c
Outdated
Comment on lines
161
to
169
| static void *http_buf_alloc(gfp_t gfp_mask, void *pool_data) | ||
| { | ||
| return kzalloc(RECV_BUFFER_SIZE, gfp_mask); | ||
| } | ||
|
|
||
| static void http_buf_free(void *element, void *pool_data) | ||
| { | ||
| kfree(element); | ||
| } |
There was a problem hiding this comment.
Move the functions to the header as static inline ones.
jserv
reviewed
Jul 6, 2025
main.c
Outdated
| return -ENOMEM; | ||
| } | ||
|
|
||
|
|
jserv
requested changes
Jul 7, 2025
Signed-off-by: Nick Huang <sef1548@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace kzalloc with mempool to reduce memory fragmentation
Using mempool improves memory allocation stability and reduces fragmentation
in high-frequency allocation scenarios, especially under memory pressure.