Skip to content

Fix tests, add py36 to tox matrix #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Feb 25, 2021

This is a small follow-up change to the recent work you've done targeting Python 3 support. In Archivematica, we're targeting Python 3.6. This pull request suggests to include py36 in the list of tox environments.

@alexdutton
Copy link
Contributor

Excellent, thank you!

@alexdutton alexdutton merged commit 59db54c into swordapp:master Feb 25, 2021
@alexdutton
Copy link
Contributor

@sevein By the way, I've yet to get round to merging #18. Would that cause you any issues I should be aware of?

@sevein sevein deleted the dev/py3-tests branch February 25, 2021 22:03
@sevein
Copy link
Contributor Author

sevein commented Feb 25, 2021

Pull request #18 works for us as long as you can update it to support py3.6, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants