Skip to content

Disable Windows Test #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iCharlesHu
Copy link
Contributor

@iCharlesHu iCharlesHu commented Jul 4, 2025

#104 was unreviewed. Reverting

@iCharlesHu iCharlesHu requested a review from itingliu July 4, 2025 04:31
Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the test hangs are not a regression from the changes being introduced in #64? The Windows tests have been consistently passing since #104 was merged, including on all the PRs open for review. Only #64 saw a hang.

If I pull the main branch and run swift test on my machine several times in a row, I don't see any hangs. However, if I pull your iCharlesHu:charles/linux-async-io branch from #64, the tests hang for me immediately.

I think we should not merge this since the evidence points to #64 being the cause of the issue.

@jakepetroules
Copy link
Contributor

Also, in case you're referring to:

Test / Windows (nightly-main - windows-2019)

...that's not hanging because of a code issue. It's hanging because GitHub removed Windows 2019 builders from their infrastructure, and the repository is misconfigured to still require successful builds of that job. We need @shahmishal to change the requirement from that one to:

Pull request / Test / Windows (6.1 - windows-2022) (pull_request)

@iCharlesHu
Copy link
Contributor Author

@jakepetroules you merged that change without any of our reviews. There's a reason why I asked tests to be setup this way so we can get through them platform by platform. Regardless whether #64 breaks the tests or not, my next PR is to completely change Windows IO so it's a bit of a moot point.

However, I can't keep this project moving if you keep blocking my workflow.

@itingliu
Copy link
Contributor

itingliu commented Jul 7, 2025

@swift-ci please test

@itingliu
Copy link
Contributor

itingliu commented Jul 7, 2025

Also, in case you're referring to:

Test / Windows (nightly-main - windows-2019)

...that's not hanging because of a code issue. It's hanging because GitHub removed Windows 2019 builders from their infrastructure, and the repository is misconfigured to still require successful builds of that job. We need @shahmishal to change the requirement from that one to:

Pull request / Test / Windows (6.1 - windows-2022) (pull_request)

I removed the 2019 one and updated to nightly/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants