Skip to content

Remove a workaround #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove a workaround #112

wants to merge 1 commit into from

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jul 3, 2025

Removes the workaround referenced in #3

@glessard glessard requested a review from iCharlesHu as a code owner July 3, 2025 21:59
Copy link
Contributor

@itingliu itingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if CI is happy

@iCharlesHu
Copy link
Contributor

Thanks!! @glessard

@glessard
Copy link
Contributor Author

glessard commented Jul 7, 2025

@swift-ci please test Windows platform

@glessard
Copy link
Contributor Author

glessard commented Jul 7, 2025

Do we need to remove the required run based on windows-2019?

@itingliu
Copy link
Contributor

itingliu commented Jul 7, 2025

@swift-ci please test

@itingliu
Copy link
Contributor

itingliu commented Jul 7, 2025

Do we need to remove the required run based on windows-2019?

I thought I did but it turned out I forgot to hit "Save"! You should be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants