Skip to content

Use labels to work properly as external dependency [IO-410] #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Use labels to work properly as external dependency [IO-410] #156

merged 1 commit into from
Jun 30, 2025

Conversation

martin4861
Copy link
Contributor

@martin4861 martin4861 commented Jun 27, 2025 •
edited
Loading

In order to properly consume rules_swiftnav as a bazel module, labels need to be used with @.

This change is backwards compatible and works with the WORKSPACE file.

@martin4861 martin4861 requested a review from a team as a code owner June 27, 2025 06:41
@martin4861 martin4861 force-pushed the martin4861/use-labels-for-ext-dependencies branch from 35a2574 to 3de38f5 Compare June 27, 2025 06:44
@martin4861 martin4861 requested review from reimerix and RReichert June 27, 2025 06:58
RReichert
RReichert approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@RReichert RReichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you verify these changes will work with orion and orion-engine.

@martin4861
Copy link
Contributor Author

make sure you verify these changes will work with orion and orion-engine.

Tests passed in
✅ starling-core
✅ orion
✅ orion-engine

@martin4861 martin4861 merged commit e7f3ae3 into main Jun 30, 2025
1 check passed
@martin4861 martin4861 deleted the martin4861/use-labels-for-ext-dependencies branch June 30, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimerix reimerix reimerix approved these changes

@RReichert RReichert RReichert approved these changes

@armallen armallen armallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin4861 @reimerix @RReichert @armallen