-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: re-evaluate derived props during teardown #16278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rectly assigned sources when reading in teardown functions
🦋 Changeset detectedLatest commit: 99f0464 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Even if there's a fix to be found for #16262 using the existing mechanism it won't fix the similar but different issue in #16072. I think we really need to widen the "keep last value on teardown" logic for props, or even make them their own signals, i.e. not pass them through but instead create "barriers" so the old value stays around. |
what's the perf impact of these changes? |
Negligible to non-existent — the only time there's any extra work at all is when reading deriveds in effect teardowns, which is rare, and it's only a tiny bit of extra work. |
alternative to #16263, made possible by #16270. Closes #16114 (but not #16262 at present, investigating)
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint