feat: linter suppressions #440
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
commented
Jul 4, 2025
| @@ -570,6 +570,22 @@ impl Workspace for WorkspaceServer { | |||
| }, | |||
| )); | |||
|
|
|||
| let suppressions = parser | |||
| .document_suppressions() | |||
| .clone() | |||
There was a problem hiding this comment.
todo: maybe we don't need to clone and can instead pull errored suppressions
juleswritescode
commented
Jul 4, 2025
| } | ||
|
|
||
| #[derive(Debug, PartialEq, Clone, Eq)] | ||
| pub(crate) enum RuleSpecifier { |
There was a problem hiding this comment.
todo: add comment
juleswritescode
commented
Jul 4, 2025
| let leading_whitespace_offset = line.len() - start_trimmed.len(); | ||
| let trimmed = start_trimmed.trim_ascii_end(); | ||
|
|
||
| assert!( |
There was a problem hiding this comment.
todo: add this to function documentation
juleswritescode
commented
Jul 4, 2025
| } | ||
|
|
||
| /// Will parse the suppressions at the start of the file. | ||
| /// As soon as anything is encountered that's not a `pgt-ignore-all` |
There was a problem hiding this comment.
todo: or empty line
juleswritescode
commented
Jul 4, 2025
| let mut eligible = vec![]; | ||
|
|
||
| // one-for-one, we're checking the lines above a diagnostic location | ||
| // until there are no more diagnostics |
There was a problem hiding this comment.
Suggested change
| // until there are no more diagnostics | |
| // until there are no more suppressions |
juleswritescode
commented
Jul 4, 2025
| } | ||
| } | ||
|
|
||
| for (line, suppr) in &self.line_suppressions { |
There was a problem hiding this comment.
todo: add comment
juleswritescode
commented
Jul 4, 2025
| [package] | ||
| authors.workspace = true | ||
| categories.workspace = true | ||
| description = "<DESCRIPTION>" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.