Skip to content

Fix new GCD issue #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Fix new GCD issue #552

wants to merge 13 commits into from

Conversation

Phrosfire
Copy link
Collaborator

@Phrosfire Phrosfire commented Jul 1, 2025

Pull Request

Bug fixes

  • A new hidden issue emerged with the gcd system where non-gcd jutsu/actions were triggering the prior gcd. I have corrected this by adjusting it so that it sets the last round used to 0 when the gcd is completed. This change seems to have fixed the issue for everything but basic actions. If you don't mind, I think I'll need assistance on getting the gcd to work properly for basic actions.

  • Users who were asleep were able to use the hospital interface to heal others

  • Staff were unable to use the village swap feature. The bloodline cost replaced the village swap cost which was causing it to show negative rep needed to transfer villages and prevented staff from switching.

New Features

  • Added a quest objective for overall medical experience and medical experience gained.
  • Created a quest type called medical
  • Added the ability for quests to grant medical experience
  • Added a new category to the missionhall for medical quests (Shared daily counter with missions).
  • Added the option to set a required medical rank for medical quests. Using the random medical option will give you a random medical quest that has an assigned rank matching the users medical rank.

Notes

I have requested an image from content for the medical option in the mission hall.

License

By making this pull request, I confirm that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the Studie-Tech ApS organization has the copyright to use and modify my contribution for perpetuity.

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 9:12pm

Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Phrosfire
Copy link
Collaborator Author

@MathiasGruber All of the changes in this PR seem to be working properly, with the exception of GCD on basic actions. When a jutsu is used it should be triggering a three round cool down for basic actions if it has a tag that's part of the shared cool down (Only Basic Clear and Basic Cleanse). Instead of a 3 round cool down, it gives it the basic actions assigned cool down.

I've been able to override it to 3, but it gets stuck as a 3 round cool down afterwards every time you use the basic action after. I am very stumped by this issue. When you have a moment, can you take a look at it for me to see if you can see a solution to it? Given the current gcd bug that was discovered, it would be good to have this fixed before the first ranked season starts.

Signed-off-by: Phrosfire <65364337+Phrosfire@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants