-
Notifications
You must be signed in to change notification settings - Fork 20
Fix new GCD issue #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix new GCD issue #552
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@MathiasGruber All of the changes in this PR seem to be working properly, with the exception of GCD on basic actions. When a jutsu is used it should be triggering a three round cool down for basic actions if it has a tag that's part of the shared cool down (Only Basic Clear and Basic Cleanse). Instead of a 3 round cool down, it gives it the basic actions assigned cool down. I've been able to override it to 3, but it gets stuck as a 3 round cool down afterwards every time you use the basic action after. I am very stumped by this issue. When you have a moment, can you take a look at it for me to see if you can see a solution to it? Given the current gcd bug that was discovered, it would be good to have this fixed before the first ranked season starts. |
Signed-off-by: Phrosfire <65364337+Phrosfire@users.noreply.github.com>
Pull Request
Bug fixes
A new hidden issue emerged with the gcd system where non-gcd jutsu/actions were triggering the prior gcd. I have corrected this by adjusting it so that it sets the last round used to 0 when the gcd is completed. This change seems to have fixed the issue for everything but basic actions. If you don't mind, I think I'll need assistance on getting the gcd to work properly for basic actions.
Users who were asleep were able to use the hospital interface to heal others
Staff were unable to use the village swap feature. The bloodline cost replaced the village swap cost which was causing it to show negative rep needed to transfer villages and prevented staff from switching.
New Features
Notes
I have requested an image from content for the medical option in the mission hall.
License
By making this pull request, I confirm that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the Studie-Tech ApS organization has the copyright to use and modify my contribution for perpetuity.