Skip to content

Add comments #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Add comments #230

merged 1 commit into from
Mar 26, 2025

Conversation

ito4303
Copy link
Contributor

@ito4303 ito4303 commented Mar 25, 2025

Added explanations on the generation of posterior predictive distribution

add explanations on the generation of posterior predictive distribution
@bob-carpenter
Copy link
Member

I'm going to merge this, but I'm a bit curious, because the comments say:

// This code generates the posterior predictive distribution
// unconditioned on the observation

A posterior predictive distribution is by definition conditioned on some observations, it's $p(\tilde{y} \mid y)$ where $\tilde{y}$ is new data and $y$ is observed data.

@bob-carpenter
Copy link
Member

P.S. Thanks for continuing to maintain this. We still use a lot of these models for bulk testing and people still use them as the basis for models they develop.

@bob-carpenter bob-carpenter merged commit d22fc71 into stan-dev:master Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants