Skip to content

feat(ske): add commands to trigger operations #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(ske): add commands to trigger operations #873

wants to merge 1 commit into from

Conversation

h3adex
Copy link
Contributor

@h3adex h3adex commented Jul 17, 2025 •
edited
Loading

Description

This PR adds the following commands:

stackit ske cluster hibernate (added a prompt for confirmation)
stackit ske cluster wakeup
stackit ske cluster maintenance (added a prompt for confirmation)
stackit ske cluster reconcile

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex h3adex requested a review from a team as a code owner July 17, 2025 15:12
@h3adex h3adex marked this pull request as draft July 17, 2025 15:12
@h3adex h3adex changed the title feat(ske): add commands to trigger hibernate, wakeup maintenance, and… feat(ske): add commands to trigger operations Jul 17, 2025
@h3adex h3adex force-pushed the feat/ske-triggers branch from c213269 to af1e398 Compare July 17, 2025 15:45
rubenhoenle
rubenhoenle reviewed Jul 18, 2025
View reviewed changes
internal/cmd/ske/cluster/wakeup/wakeup_test.go
var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &ske.APIClient{}
var testProjectId = uuid.NewString()
var testRegion = "eu01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var testRegion = "eu01"
const(
testRegion = "eu01"
testClusterName = "my-cluster"
)

rubenhoenle
rubenhoenle reviewed Jul 18, 2025
View reviewed changes
internal/cmd/ske/cluster/reconcile/reconcile_test.go
var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &ske.APIClient{}
var testProjectId = uuid.NewString()
var testRegion = "eu01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

rubenhoenle
rubenhoenle reviewed Jul 18, 2025
View reviewed changes
internal/cmd/ske/cluster/maintenance/maintenance_test.go
var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &ske.APIClient{}
var testProjectId = uuid.NewString()
var testRegion = "eu01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

rubenhoenle
rubenhoenle reviewed Jul 18, 2025
View reviewed changes
internal/cmd/ske/cluster/hibernate/hibernate_test.go
var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
var testClient = &ske.APIClient{}
var testProjectId = uuid.NewString()
var testRegion = "eu01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenhoenle rubenhoenle rubenhoenle left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h3adex @rubenhoenle