Allow Table and Column name expressions to return SqlIdentifier #2077
Conversation
Signed-off-by: Sergey Korotaev <sergey.evgen.kor2501@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
| */ | ||
| class BasicRelationalPersistentEntity<T> extends BasicPersistentEntity<T, RelationalPersistentProperty> | ||
| implements RelationalPersistentEntity<T> { | ||
|
|
||
| private static final SpelExpressionParser PARSER = new SpelExpressionParser(); | ||
|
|
||
| private final Lazy<SqlIdentifier> tableName; | ||
| private final @Nullable Expression tableNameExpression; | ||
| private final Lazy<SqlIdentifier> tableNameExpression; |
There was a problem hiding this comment.
That's not what was meant here. We should remain with Expression (or switch to ValueExpression).
It was rather meant that a Expression (respective ValueExpression) should be able to return an SqlIdentifier and not be forced to return a String (as it is done now).
We also want to evaluate the expression each time we obtain names and we don't want to introduce caching.
There was a problem hiding this comment.
Sorry but perhaps I don't understand correctly. I see that ExpressionEvaluator returns String from Expression. Do you mean about it that no it is forced to return a String and should be able to return an SqlIdentifier? Like this
String result = expression.getValue(provider.getEvaluationContext(null), String.class);
Roughly, here we need to return SqlIdentifier, right?
By #1524