-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Oracle: add OracleChatMemory support #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: fanxt0218 <3515228784@qq.com>
@fanxt0218 Thanks for the PR! Could you add the schema and the corresponding integration test? |
Signed-off-by: fanxt0218 <3515228784@qq.com>
Ok, I've added oracle's schema and integration test classes and made it a new commit. Please review |
In another PR #3590 , a new scaling method was implemented for all databases. However, this scaling method is not implemented in Oracle Database, so it can be problematic when merging. To keep their behavior consistent, I'm going to request another commit to fix this. Make sure they are fully compatible when they merge in the future |
Signed-off-by: fanxt0218 <3515228784@qq.com>
This PR is merged after another PR is merged, and the method comment is undone |
Signed-off-by: fanxt0218 <3515228784@qq.com>
add the support for oracle