Skip to content

Use plugins per protocol approach #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: decaf
Choose a base branch
from
Open

Use plugins per protocol approach #311

wants to merge 2 commits into from

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Jul 8, 2025

Went back and forth on this a lot over the past few months. This approach is to just use one protocol per plugin.

Main advantages:

  • protocols can set their own configs onto the client, like for codecs, simple json, or even stubbing.
  • no special casing of welds - protocols are just plugins. Ordering still is necessary at the weld level.
  • Protocol handlers act on listeners (over the wire) instead of on parsing a body into a string io and then parsing into a data structure.

Quirks (maybe or maybe cons):

  • no protocol config option - protocols can be removed or swapped out at the client class level like any other plugin
  • new protocols are also plugin/handler based

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant