User Agent #310
Open
User Agent #310
+116
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardwang1124
commented
Jul 3, 2025
mullermp
reviewed
Jul 3, 2025
mullermp
approved these changes
Jul 9, 2025
| module Client | ||
| module Plugins | ||
| class UserAgent < Plugin | ||
| option(:user_agent_suffix) |
There was a problem hiding this comment.
In v3 this was secret. I think we should fully document this as a public option in the generic client. In v4 we can keep it secret or remove it. Or, we can use app id concept instead. Let's discuss
gems/smithy-client/spec/smithy-client/plugins/user_agent_spec.rb
Outdated
Show resolved
Hide resolved
gems/smithy-client/spec/smithy-client/plugins/user_agent_spec.rb
Outdated
Show resolved
Hide resolved
gems/smithy-client/spec/smithy-client/plugins/user_agent_spec.rb
Outdated
Show resolved
Hide resolved
mullermp
reviewed
Jul 10, 2025
|
|
||
| require_relative '../../spec_helper' | ||
|
|
||
| require 'smithy-client/plugins/user_agent' |
There was a problem hiding this comment.
Require is not necessary anymore
| option( | ||
| :user_agent_suffix, | ||
| doc_type: String, | ||
| docstring: 'The suffix appended to the user agent string.' |
jterapin
reviewed
Jul 10, 2025
Comment on lines
137
to
143
| def with_metric(&block) | ||
| Thread.current[:aws_sdk_core_user_agent_metric] ||= [] | ||
| Thread.current[:aws_sdk_core_user_agent_metric] << 'C' | ||
| block.call | ||
| ensure | ||
| Thread.current[:aws_sdk_core_user_agent_metric].pop | ||
| end |
There was a problem hiding this comment.
Should we put a TODO to revisit this approach? Just want to make sure that this does not go amiss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user agent plugin and test.