-
Notifications
You must be signed in to change notification settings - Fork 21
Pure python request pipeline #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JordonPhillips
wants to merge
13
commits into
develop
Choose a base branch
from
pure-python-request-pipeline
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2cacaf3
Implement the request pipeline in pure python
JordonPhillips a07082b
Replace code generated request pipeline
JordonPhillips 6df2d87
Set default namespace for json codec
JordonPhillips f9d6bdb
Use TypeForm for events
JordonPhillips 1c65e4b
Check for enum response bodies
JordonPhillips e477381
Headers are never null
JordonPhillips 754ed2d
Serialize float headers correctly
JordonPhillips 618d663
Handle medaitype in headers
JordonPhillips 58e2192
Call read_data_stream on data streams
JordonPhillips 92a3056
Don't serialize content-length without content-type
JordonPhillips 7e34bde
Update protocol test skip list
JordonPhillips fdf7ee2
Merge signer/identity properties
JordonPhillips 2dce401
Log endpoint params
JordonPhillips File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
807 changes: 77 additions & 730 deletions
807
codegen/core/src/main/java/software/amazon/smithy/python/codegen/ClientGenerator.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ | |
import software.amazon.smithy.model.shapes.StructureShape; | ||
import software.amazon.smithy.model.shapes.TimestampShape; | ||
import software.amazon.smithy.model.shapes.UnionShape; | ||
import software.amazon.smithy.model.traits.StreamingTrait; | ||
import software.amazon.smithy.python.codegen.GenerationContext; | ||
import software.amazon.smithy.python.codegen.SymbolProperties; | ||
import software.amazon.smithy.python.codegen.writer.PythonWriter; | ||
|
@@ -100,7 +101,11 @@ private void writeSchema() { | |
|
||
@Override | ||
public Void blobShape(BlobShape shape) { | ||
writeDeserializer(shape); | ||
if (shape.hasTrait(StreamingTrait.class)) { | ||
writeDeserializer("data_stream"); | ||
} else { | ||
writeDeserializer(shape); | ||
} | ||
Comment on lines
+104
to
+108
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's unique with the data_stream here that shape isn't accounting for? Just that it's an unknown length/shape? |
||
return null; | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we cataloged all the breaking changes somewhere so we know what to put in the release notes?