Skip to content

Added encoding lib #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added encoding lib #14

wants to merge 4 commits into from

Conversation

flrnmrz
Copy link
Contributor

@flrnmrz flrnmrz commented Feb 7, 2019

No description provided.


## Notes

* A Golang driver development project requires golang's `go` command line tool
Copy link

@iurkol iurkol Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn't we add the link for the reader's convenience: https://golang.org/doc/install#install

```yaml
type: golang
metadata:
name: "<drivern ame>"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"drivern ame" != "driver name"

it is necessary to login to the target registry first:

```shell
$ drivers login <server> <username> -p <password>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't remind the reader where this stuff goes from: server, username and password?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants