Skip to content

SADR-6590: initial followup from Prebid feedback #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

jefftmahoney
Copy link

Addressing initial feedback from Prebid.

@jefftmahoney jefftmahoney self-assigned this Nov 7, 2024
tcfeu_supported: true
coppa_supported: true
dsa_supported: false // TODO: SADR-6590: is this supported?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is supported

coppa_supported: true
gpp_sids: tcfeu, usp
schain_supported: true
dchain_support: false // TODO: SADR-6590: saw no evidence that we support this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, not supported

userIds: all
media_types: banner
safeframes_ok: false // TODO: SADR-6590: is this supported?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supported

userIds: all
media_types: banner
safeframes_ok: false // TODO: SADR-6590: is this supported?
deals_supported: false // TODO: SADR-6590: is this supported?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, not supported

pbjs: true
pbs: true
floors_supported: true
prebid_member: false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid // TODO: SADR-6590: will-bid-on-one?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will-bid-on-one

floors_supported: true
prebid_member: false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid // TODO: SADR-6590: will-bid-on-one?
ortb_blocking_supported: false // TODO: SADR-6590: is this supported?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supported

@jefftmahoney jefftmahoney merged commit e941973 into master Nov 8, 2024
1 check passed
krzysztofequativ pushed a commit that referenced this pull request Jun 27, 2025
…rameters (prebid#6043)

* fix spelling

* Agt 454 group changes (prebid#13)

* AGT-403: Add adType parameter description

* Merge pull request #2 from DimaIntentIQ/AGT-466-module-reporting-placement-id-unit-code

IntentIq ID & Analytics Modules: placementId parameter documentation

* IntentIq ID: Documentation for sourceMetaData and sourceMetaDataExternal (#5)

* Fix table

* AGT-453: Documentation for sourceMetaData

* fix docs and add docs (#6)

* AGT-498: reportMethod description (#7)

* add groupchanged param docs

* remove/add new lines

* Add missed params

---------

Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>

---------

Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com>
Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants