Skip to content

Resolve small errors tripping up our CI process #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Jul 1, 2025

Linked Issue

Closes #3583

Description

Resolves a number of small issues tripping up our CI checks:

  • Resolved onclick type bug for Popover components. This was missing a required import to function.
  • Additionally, this also resolves a type error in the Theme Generator app
  • Resolve type errors with generate-scheme.ts in the Docs app

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changsets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

@endigo9740 endigo9740 linked an issue Jul 1, 2025 that may be closed by this pull request
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: ae08208

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www.skeleton.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 4:36pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
themes.skeleton.dev ⬜️ Ignored (Inspect) Jul 1, 2025 4:36pm

@endigo9740 endigo9740 changed the title Bugfix for missing type import in Svelte package Resolve small errors tripping up our CI process Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolved onclick type bug for Popover components
1 participant