Feat/db migration #586
Open
Feat/db migration #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylembachar
reviewed
Apr 7, 2025
rolling-shutter/keyperimpl/gnosis/database/sql/migrations/V2_validatorRegistrations.sql
Outdated
Show resolved
Hide resolved
blockchainluffy
force-pushed
the
feat/db-migration
branch
from
eb93d11 to
34e270f
Compare
jannikluhn
approved these changes
May 28, 2025
|
|
||
| ALTER TABLE validator_registrations | ||
| DROP CONSTRAINT validator_registrations_pkey, | ||
| ADD PRIMARY KEY (block_number, tx_index, log_index, validator_index); |
There was a problem hiding this comment.
What's the motivation for this change? Currently, the primary key is (block_number, tx_index, log_index). The validator registry emits one log per registration (which contains the signature), so adding the validator index does neither constrain it more or less.
There was a problem hiding this comment.
We need to integrate AggregateRegistrationMessage, in which more than one validators can submit signatures in a single transaction.
The above constraint was failing as it only allowed one validator index to be added in a single transaction.
Co-authored-by: jannikluhn <jannik@brainbot.com>
Co-authored-by: jannikluhn <jannik@brainbot.com>
|
@ylembachar not merging this PR, as we might need to release it in later/separate version. Please feel free to merge it when we want to do this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/migrationsdir of the related schemavalidator_registrationstable