Split-off download_file_from_url method from download_attachment #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load_attachment method
|
It looks like all the unit tests are failing every test, is that something I did or is there something else at play? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #387
This pull request introduces a new method,
download_file_from_url, to improve the flexibility of downloading files from Shotgun. The most important changes are outlined below:New functionality for file downloads:
download_file_from_urlmethod inshotgun_api3/shotgun.pyto allow downloading files directly using a provided URL. This method can handle Shotgun attachments as well as other files, such as thumbnails. It supports saving files to disk or returning the file data.