Discipline annotations #2231
Open
Discipline annotations #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbacall
commented
Jun 26, 2025
fbacall
commented
- Allows projects and workflows to be annotated with scientific disciplines.
- Propagates disciplines set on a project down to workflows under that project (if they do not already have any disciplines set).
- Refactors how default policies/licenses are handled, fetching them with an AJAX call rather than storing a mapping on the page.
- Moves investigation/study select field to the "manage" pages of studies/assays.
…ck of JSON on page
and make sure implicit project selector works (for setting default policies)
stuzart
requested changes
Jun 27, 2025
| @@ -0,0 +1,32 @@ | |||
| # Made up from a subset of EDAM Topics, plus some others | |||
| DISCIPLINES = [ | |||
There was a problem hiding this comment.
this needs to go in the upgrade tasks
| @@ -61,6 +61,8 @@ | |||
|
|
|||
| <%= render partial: 'assets/controlled_vocab_annotations_form_properties', locals: { resource: @workflow } %> | |||
|
|
|||
| <%= render partial: 'assets/controlled_vocab_annotations_form_property', locals: { resource: @workflow, property: :disciplines} -%> | |||
There was a problem hiding this comment.
could this be included in assets/controlled_vocab_annotations_form_properties for consistency and so they are always grouped together
| @@ -62,6 +61,8 @@ | |||
| <%= render :partial=> "projects/select_add_current_user_to_project" %> | |||
| <% end %> | |||
|
|
|||
| <%= render partial: "assets/controlled_vocab_annotations_form_property", locals: { resource: @project, property: :disciplines} -%> | |||
There was a problem hiding this comment.
I think it would be better if this was placed next to Topics, since the are related, or better replace both with an updated assets/controlled_vocab_annotations_form_properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.