Skip to content

Asychronous import and updates when applying Fair Data Station rdf #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Jul 2, 2025
Merged

Asychronous import and updates when applying Fair Data Station rdf #2210

merged 51 commits into from
Jul 2, 2025

Conversation

stuzart
Copy link
Member

@stuzart stuzart commented Jun 9, 2025

stuzart added 30 commits May 14, 2025 11:37
@stuzart
create new model FairDataStationUpload #2197
a8b99af 
also linked to appropriate associations with validations.
@stuzart
include the purpose as an enum #2197
bd1bf04
@stuzart
fix silly error #2197
931cc22
@stuzart
add Policy to FairDataStationUpload #2197
3de4a3e
@stuzart
handle creating the FairDataStationUpload record for the submit_faird…
fa84fdd 
…ata_station action #2197
@stuzart
queue the job #2197
a66c637
@stuzart
perform the job #2197
dd44b80
@stuzart
removed forced throwing forward of exception #2197
051d335
@stuzart
hacky first version of tracking and showing the import status #2197
11d7cc0
@stuzart
test coverage for showing the import status, and preventing improper …
d9607e1 
…access to the status method #2197
@stuzart
show the external id alongside the upload being imported #2197
2d57a0d
@stuzart
check the errors are recorded in the task, including add the short er…
e142c35 
…ror message to the task object #2197
@stuzart
refactored shorter names for the tasks and some cody tidying with rub…
857636d 
…ocop #2197
@stuzart
add a flag whether the status should be shown, to give the ability to c…
1dd41c8 
…lose #2197
@stuzart
action to change the show_status flag for fairdatastationupload, with…
d44b5f8 
… protections against updating when not allowed #2197
@stuzart
javascript to close the import status #2197
a40e175
@stuzart
bootstrap based close alert icon #2197
488206d
@stuzart
cleaned up the import page, and show the import statuses in a panel #…
c7f403d 
…2197
@stuzart
submitting the TTL for update creates the record and queues job #2197
9929d07
@stuzart
refactored matching_updates_in_progress to be based in investigation …
a2e0ad5 
…rather than project #2197
@stuzart
perform the update job #2197
fc9a181
@stuzart
test for when the update job fails #2197
32a9994
@stuzart
fix/remove failing tests #2197
172876f
@stuzart
moved obselete functional test for ignoring disabled EMT's over to th…
142679b 
…e unit tests #2197
@stuzart
print some info about RDF::Query::Solution when test randomly fails #…
2240c2a 
…2197
@stuzart
show and update the update job status #2197
48d925f
@stuzart
better controls over preventing a new update whilst one is currently …
1b96866 
…in progress #2197
@stuzart
handle the action to close the status item #2197
6930cb2
@stuzart
a dedicated fair data station helper #2197
88f5e87
@stuzart
updated tests #2197
9f7b16a
@stuzart stuzart requested a review from Copilot June 13, 2025 13:10
Copilot

This comment was marked as outdated.

Sign in to view

@stuzart stuzart marked this pull request as ready for review June 16, 2025 08:13
@stuzart stuzart requested review from whomingbird and fbacall June 16, 2025 08:14
fbacall
fbacall reviewed Jun 17, 2025
View reviewed changes
whomingbird
whomingbird reviewed Jun 18, 2025
View reviewed changes
whomingbird
whomingbird reviewed Jun 18, 2025
View reviewed changes
@stuzart stuzart requested a review from Copilot June 23, 2025 13:54
Copilot

This comment was marked as duplicate.

Sign in to view

@stuzart stuzart requested review from fbacall and whomingbird June 24, 2025 09:53
@stuzart stuzart added this to the 1.17.0 milestone Jun 24, 2025
@stuzart stuzart moved this to In review in SEEK 1.17.x Jun 24, 2025
fbacall
fbacall approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with the Copilot comment that it might be nicer if the logic in the submit_fairdata_station actions was extracted out somewhere (Seek::FairDataStation::Importer or something), not a blocker though.

@stuzart
Copy link
Member Author

stuzart commented Jul 1, 2025

I think I agree with the Copilot comment that it might be nicer if the logic in the submit_fairdata_station actions was extracted out somewhere (Seek::FairDataStation::Importer or something), not a blocker though.

It's something I'd like to revisit in some future work or a specific issue

@stuzart
Merge branch 'main' into async-fds-2197
3206498 
# Conflicts:
#	app/assets/javascripts/application.js
#	db/schema.rb
@stuzart stuzart merged commit c84a0b9 into main Jul 2, 2025
32 of 33 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Jul 2, 2025
@stuzart stuzart deleted the async-fds-2197 branch July 2, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@fbacall fbacall fbacall approved these changes

@whomingbird whomingbird Awaiting requested review from whomingbird

Assignees
No one assigned
Labels
None yet
Projects
SEEK 1.17.x
Status: Done
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stuzart @fbacall @whomingbird