Skip to content

Add missing @no-named-arguments annotations and ensure there won't be new missing ones anymore #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 11.5
Choose a base branch
from

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Jun 15, 2025

This PR:

  • Updates "Run PHP-CS-Fixer" step in CI
  • Adds custom fixers to tools
  • Updates PHP CS Fixer config
  • Fix the codebase according to the new config (by adding missing @no-named-arguments annotations)

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I am reluctant to merge it as I am already not happy that I have to use Composer to install PHPStan in order to use PHPStan plugins and this introduces a similar approach for PHP-CS-Fixer.

@kubawerlos
Copy link
Contributor Author

I am already not happy that I have to use Composer to install PHPStan

Is there something wrong with it? I thought (based on how PHPStan is installed and used on main branch) that the goal is to have all code in tools, so Composer is only needed to update tools and never to use them.

How would you like to have the tools installed then? With phive?

@kubawerlos kubawerlos marked this pull request as ready for review June 15, 2025 07:43
@kubawerlos
Copy link
Contributor Author

kubawerlos commented Jun 15, 2025

Anyway, I've finished this PR. Feel free to cherry-pick some commits (if any) and close it.

Let me know how I can help to automate PHPStan and PHP CS Fixer the way you want them to be.

Or maybe if there is no such plan yet, we could go with this PR up to main branch (as there are new files with missing @no-named-arguments) for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants