Skip to content

feat: use blockscout chart #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 31, 2024
Merged

feat: use blockscout chart #199

merged 20 commits into from
Oct 31, 2024

Conversation

sbaizet-ledger
Copy link
Member

No description provided.

Copy link
Contributor

@dghelm dghelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we need to add blockscout-backend as an ingress value in config.toml so the CLI script will modify the production.yaml.

We may also want to wait to merge until we hear back on how to make things work without TLS for local devnet.

# nginx.ingress.kubernetes.io/cors-allow-headers: "updated-gas-oracle, Content-Type, Authorization"
# nginx.ingress.kubernetes.io/cors-allow-methods: "GET, POST, OPTIONS"
# nginx.ingress.kubernetes.io/cors-max-age: "86400"
hostname: "blockscout-backend.hsk.scroll.systems"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be blank, correct? And we'll want to add backend URL to the config.toml ingress section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made commit to add to scroll-sdk and examples folder config.tomls

hostname: "blockscout-backend.hsk.scroll.systems"
tls:
enabled: true
secretName: blockscout-tls # Set here the hostname for the ingress. Example : blockscout-backend.scrollsdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment isn't correct. Also, can we call this blockscout-backend-tls (otherwise the secrets use a different convention than the default URLs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I now see what you were doing here -- it needs a host section... do we want to specify TLS here when we haven't done that for any other services? Can we leave it mostly commented out for usage with devnet -- assuming disabling ECTO_USE_SSLand ETHEREUM_JSONRPC_HTTP_INSECURE fix localhost usage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was starting to provide kind of a documentation inside the value file.
True that we haven't done that for the other services but we might consider this.
Not needed now though.

@dghelm
Copy link
Contributor

dghelm commented Oct 26, 2024

Also, after production.yaml is finalized, can you make a copy in examples/values/blockscout-production.yaml?

@yiweichi
Copy link
Member

should we also update l1-explorer to the latest version of blockscout?

@dghelm
Copy link
Contributor

dghelm commented Oct 30, 2024

Alerting to #209 which is ready to be merged, but don't want to add more conflicts if you're already resolving.

@sbaizet-ledger sbaizet-ledger merged commit 32da821 into develop Oct 31, 2024
5 of 7 checks passed
@sbaizet-ledger sbaizet-ledger deleted the feat-blockscout-chart branch October 31, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants