Skip to content

feat: add flags to disable tx broadcast & receive #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add flags to disable tx broadcast & receive #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bafcf7e
feat: add flag to disable tx broadcast & receive
yiweichi Jun 26, 2025
fb6f62a
fix: test
yiweichi Jul 1, 2025
a47dbd5
fix: test
yiweichi Jul 4, 2025
a9f1319
refactor: remove fields on ScrollNode
yiweichi Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/node/src/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,12 @@ pub struct NetworkArgs {
/// A bool that represents if the scroll wire protocol should be enabled.
#[arg(long = "network.scroll-wire", default_value_t = true)]
pub enable_scroll_wire: bool,
/// A bool that represents if the transaction broadcast should be disabled.
#[arg(long = "network.disable-tx-broadcast", default_value_t = false)]
pub disable_tx_broadcast: bool,
/// A bool that represents if the transaction receiving should be disabled.
#[arg(long = "network.disable-tx-receive", default_value_t = false)]
pub disable_tx_receive: bool,
}

/// The arguments for the L1 provider.
Expand Down
4 changes: 4 additions & 0 deletions crates/node/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ where
best_transactions: (),
},
))
.network(ScrollNetworkBuilder {
disable_txpool_broadcast: self.config.network_args.disable_tx_broadcast,
disable_txpool_receive: self.config.network_args.disable_tx_receive,
})
}

fn add_ons(&self) -> Self::AddOns {
Expand Down
10 changes: 2 additions & 8 deletions crates/node/src/test_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,7 @@ pub async fn generate_tx(wallet: Arc<Mutex<Wallet>>) -> Bytes {
pub fn default_test_scroll_rollup_node_config() -> ScrollRollupNodeConfig {
ScrollRollupNodeConfig {
test: true,
network_args: crate::args::NetworkArgs {
enable_eth_scroll_wire_bridge: true,
enable_scroll_wire: true,
},
network_args: crate::args::NetworkArgs::default(),
database_args: DatabaseArgs { path: Some(PathBuf::from("sqlite::memory:")) },
l1_provider_args: L1ProviderArgs::default(),
engine_driver_args: EngineDriverArgs { en_sync_trigger: 100 },
Expand All @@ -147,10 +144,7 @@ pub fn default_test_scroll_rollup_node_config() -> ScrollRollupNodeConfig {
pub fn default_sequencer_test_scroll_rollup_node_config() -> ScrollRollupNodeConfig {
ScrollRollupNodeConfig {
test: true,
network_args: crate::args::NetworkArgs {
enable_eth_scroll_wire_bridge: true,
enable_scroll_wire: true,
},
network_args: crate::args::NetworkArgs::default(),
database_args: DatabaseArgs { path: Some(PathBuf::from("sqlite::memory:")) },
l1_provider_args: L1ProviderArgs::default(),
engine_driver_args: EngineDriverArgs { en_sync_trigger: 100 },
Expand Down
10 changes: 2 additions & 8 deletions crates/node/tests/e2e.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ async fn can_bridge_l1_messages() -> eyre::Result<()> {
let chain_spec = (*SCROLL_DEV).clone();
let node_args = ScrollRollupNodeConfig {
test: true,
network_args: ScrollNetworkArgs {
enable_eth_scroll_wire_bridge: true,
enable_scroll_wire: true,
},
network_args: ScrollNetworkArgs::default(),
database_args: DatabaseArgs { path: Some(PathBuf::from("sqlite::memory:")) },
l1_provider_args: L1ProviderArgs::default(),
engine_driver_args: EngineDriverArgs::default(),
Expand Down Expand Up @@ -99,10 +96,7 @@ async fn can_sequence_and_gossip_blocks() {
let chain_spec = (*SCROLL_DEV).clone();
let rollup_manager_args = ScrollRollupNodeConfig {
test: true,
network_args: ScrollNetworkArgs {
enable_eth_scroll_wire_bridge: true,
enable_scroll_wire: true,
},
network_args: ScrollNetworkArgs::default(),
database_args: DatabaseArgs { path: Some(PathBuf::from("sqlite::memory:")) },
l1_provider_args: L1ProviderArgs::default(),
engine_driver_args: EngineDriverArgs::default(),
Expand Down
4 changes: 2 additions & 2 deletions crates/sequencer/tests/e2e.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ async fn can_sequence_blocks_with_private_key_file() -> eyre::Result<()> {
let chain_spec = (*SCROLL_DEV).clone();
let rollup_manager_args = ScrollRollupNodeConfig {
test: false, // disable test mode to enable real signing
network_args: NetworkArgs { enable_eth_scroll_wire_bridge: true, enable_scroll_wire: true },
network_args: NetworkArgs::default(),
database_args: DatabaseArgs { path: Some(PathBuf::from("sqlite::memory:")) },
l1_provider_args: L1ProviderArgs::default(),
engine_driver_args: EngineDriverArgs::default(),
Expand Down Expand Up @@ -514,7 +514,7 @@ async fn can_sequence_blocks_with_hex_key_file_without_prefix() -> eyre::Result<
let chain_spec = (*SCROLL_DEV).clone();
let rollup_manager_args = ScrollRollupNodeConfig {
test: false, // disable test mode to enable real signing
network_args: NetworkArgs { enable_eth_scroll_wire_bridge: true, enable_scroll_wire: true },
network_args: NetworkArgs::default(),
database_args: DatabaseArgs { path: Some(PathBuf::from("sqlite::memory:")) },
l1_provider_args: L1ProviderArgs::default(),
engine_driver_args: EngineDriverArgs::default(),
Expand Down
Loading