feat(feynman): support codecv8 in rollup-verifier

[colinlyguo]

1. Purpose or design rationale of this PR

This PR adds support for codecv8. e.g., to ensure batch hashes of codecv8 are calculated correctly.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change

Summary by CodeRabbit

• Chores
  • Updated an internal dependency to the latest version.
  • Increased the patch version number to 58.
• Bug Fixes
  • Improved batch version handling to support a broader range of codec versions.
• Tests
  • Added new tests to validate batch processing with the latest codec version.

[coderabbitai]

Warning

Rate limit exceeded

@Thegaram has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3cc301a and ec85eac.

📒 Files selected for processing (1)

• params/version.go (1 hunks)

Walkthrough

The changes update the version of the github.com/scroll-tech/da-codec dependency in the go.mod file and increment the patch version constant from 57 to 58 in params/version.go. Batch codec version checks in rollup_sync_service.go were broadened from an exact match with CodecV7 to a range check for versions greater or equal to CodecV7, with corresponding error message updates. A new test for batch validation using CodecV8 was added in rollup_sync_service_test.go.

Changes

File(s)	Change Summary
go.mod	Updated github.com/scroll-tech/da-codec dependency to a newer version.
params/version.go	Incremented VersionPatch constant from 57 to 58.
rollup/rollup_sync_service/rollup_sync_service.go	Changed batch codec version checks from exact CodecV7 to >= CodecV7, updated related comments and error messages.
rollup/rollup_sync_service/rollup_sync_service_test.go	Added TestValidateBatchCodecV8 to test batch validation logic for CodecV8 batches.

Possibly related PRs

• fix(rollup-verifier): update da-codec dependency #1207: Updated the da-codec dependency and incremented version patch, similar to this PR’s dependency update and version bump.
• feat(L1 follower and rollup verifier): support CodecV7 in L1 follower mode and rollup verifier #1105: Added CodecV7 support and versioned committed batch metadata handling, which this PR extends to CodecV8 and broadens version checks.

Suggested labels

bump-version

Suggested reviewers

• Thegaram

Poem

A hop, a skip, a version bump,
Codec freshened, thump-thump-thump!
Patch now fifty-eight, hooray,
New checks and tests to lead the way.
Batches validated, code’s in tune—
Rabbits dance beneath the moon! 🐇🌙

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jonastheis]

I think this needs to be updated:

go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go

Line 473 in 141a8df

if commitedBatch.Version() == encoding.CodecV7 {

It would be good to add some test cases with CodecV8 to the rollup verifier to make sure it works as expected.

[colinlyguo]

I think this needs to be updated:

go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go

Line 473 in 141a8df

if commitedBatch.Version() == encoding.CodecV7 {

It would be good to add some test cases with CodecV8 to the rollup verifier to make sure it works as expected.

Oh, nice catch. will add.

[colinlyguo]

I think this needs to be updated:

go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go

Line 473 in 141a8df

if commitedBatch.Version() == encoding.CodecV7 {

It would be good to add some test cases with CodecV8 to the rollup verifier to make sure it works as expected.

Added in this commit: 27168a2.