fix: check ancient header hash after decoding

[omerfirmak]

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
• ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
• docs: Documentation-only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes
  • Enhanced data validation to ensure only consistent and accurate historical data is returned.
• Refactor
  • Streamlined the data retrieval process by removing redundant checks, resulting in improved reliability and efficiency.
• Chores
  • Updated the patch version to reflect the latest release.

[coderabbitai]

Walkthrough

This change modifies the header data retrieval functions in core/rawdb/accessors_chain.go. The ReadHeaderRLP function now skips hash verification and simply checks if the returned data length is greater than zero. In contrast, the ReadHeader function adds a post-decoding validation that confirms the decoded header’s hash matches the provided hash, returning nil if not. Additionally, the dependency on the crypto package has been removed. The patch version in params/version.go has been incremented from 33 to 34.

Changes

File	Changes Summary
core/.../accessors_chain.go	Removed the crypto package dependency; in ReadHeaderRLP, removed hash comparison and now just checks data length; in ReadHeader, added post-decode hash verification returning nil on mismatch.
params/version.go	Updated the VersionPatch constant from 33 to 34.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ReadHeaderRLP
    participant Database
    Client->>ReadHeaderRLP: Request header data (RLP)
    ReadHeaderRLP->>Database: Retrieve header RLP data
    Database-->>ReadHeaderRLP: Return data blob
    ReadHeaderRLP->>ReadHeaderRLP: Check if data length > 0
    alt Data exists
        ReadHeaderRLP-->>Client: Return header data
    else Data missing
        ReadHeaderRLP-->>Client: Return nil or error
    end

Loading

sequenceDiagram
    participant Client
    participant ReadHeader
    participant Database
    Client->>ReadHeader: Request header by hash
    ReadHeader->>Database: Retrieve RLP header data
    Database-->>ReadHeader: Return header data blob
    ReadHeader->>ReadHeader: Decode header from RLP
    ReadHeader->>ReadHeader: Verify decoded header hash against provided hash
    alt Hash matches
        ReadHeader-->>Client: Return valid header
    else Hash mismatch
        ReadHeader-->>Client: Return nil
    end

Loading

Possibly related PRs

• fix(verifier,l1follower): update da-codec to latest version #1143: The changes in the main PR, specifically in the params/version.go file, are related to the updates made in the retrieved PR where the VersionPatch constant is also modified, indicating a direct connection at the code level.

Suggested reviewers

• georgehao
• colinlyguo
• Thegaram

Poem

I'm just a rabbit in the code-filled glen,
Hoping to nibble bugs now and then.
I saw the headers dance and play,
Validations now light the way.
With joyful hops, these changes are prime,
Celebrated in code and rhythmic rhyme! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7b0211 and c061f30.

📒 Files selected for processing (1)

• params/version.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• params/version.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (go)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.