Skip to content

typing annotations and small optimisations in hasse_diagram.py #40342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

typing annotations and small optimisations in hasse_diagram.py #40342

wants to merge 3 commits into from

Conversation

fchapoton
Copy link
Contributor

In the modified file:

  • adding a bunch of fine typing annotations
  • fix the documentation about storage, not using matrices now
  • enhance some methods, that get slightly faster

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2025 •
edited
Loading

Documentation preview for this PR (built with commit b06630d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mantepse
mantepse reviewed Jul 1, 2025
View reviewed changes
mantepse
mantepse reviewed Jul 1, 2025
View reviewed changes
@fchapoton
Update hasse_diagram.py
b06630d 
voilà, voilà
@mantepse
Copy link
Contributor

mantepse commented Jul 1, 2025

thank you!

@fchapoton
Copy link
Contributor Author

Und viel danke, Martin, für deine hilfe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantepse mantepse mantepse left review comments

Assignees
No one assigned
Labels
c: combinatorics s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @mantepse