Fix 32-bit segfault in m4ri #40338
Open
Fix 32-bit segfault in m4ri #40338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding upstream patch from malb/m4ri#28
|
@tornaria would be nice to fix the 32-bit buildbot |
|
Documentation preview for this PR (built with commit 3a8ce34; changes) is ready! 🎉 |
|
I'm sorry, I don't really know how the buildbot works. I do maintain m4ri (and a lot of other sagemath dependencies) for void linux and I do check 32 bit. I try to fix and contribute back via upstream, but I'm not a user of sage-the-distro. |
|
@tornaria All I'm saying is: you should approve this PR since you wrote the upstream patch ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding upstream patch from malb/m4ri#28