Skip to content

get rid of some "is_commutative" methods, via the category framework #40328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

Using the idea that, by default, a ring is not commutative unless it belongs to the category of CommutativeRings.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

Documentation preview for this PR (built with commit 3c0d1cd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

user202729 commented Jun 28, 2025

the assignment to self._category looks questionable (these objects inherit from CategoryObject which has a cdef _category field, but that is different from the field accessible from Python code, which is confusing), but should be out of scope here.

@fchapoton
Copy link
Contributor Author

thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants