Add Curiel–Genitrini unranking algorithm #40318

hugo-a-04 · 2025-06-27T14:15:42Z

Commits:
-Add the function "compare_subsets"
-Add the function "compare_set_partitions"
-Add Curiel-Genitrini unranking algorithm

This PR introduces the unranking algorithm for lexicographic order.

…sequential_form, sequential_to_canonical_form

…on([])

…put unranking

…sion wasn't update)

fchapoton · 2025-06-27T19:51:01Z

src/sage/combinat/set_partition.py

@@ -13,6 +13,9 @@
 - Martin Rubey (2017-10-10): Cleanup, add crossings and nestings, add
  random generation.

+- Anciaux Hugo, Rachid Bouhmad, Elhadj Alseiny Diallo, Do Truong Thinh Truong ( Algorithms Design : Amaury Curiel, Genitrini Antoine ).


tout le monde sous la forme "prénom nom" SVP

github-actions · 2025-06-27T23:02:45Z

Documentation preview for this PR (built with commit 02a47cc; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

src/sage/combinat/set_partition.py

mantepse · 2025-06-28T09:02:36Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([1, 3], [1, 3, 4])
+        True
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:03:14Z

src/sage/combinat/set_partition.py

+    - But `{1, 4}` is not less than `{1, 3, 4}`:
+
+    ::
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:03:29Z

src/sage/combinat/set_partition.py

+    TESTS:
+
+    ::
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:03:41Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([2,5], [2,5])
+        True
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:03:54Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([],[])
+        True
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:04:06Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([], [1])
+        True
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:04:17Z

src/sage/combinat/set_partition.py

+        sage: compare_subsets([1], [])
+        False
+
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:04:29Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([1, 2], [3, 4])
+        True
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:04:42Z

src/sage/combinat/set_partition.py

+        sage: compare_subsets([4,5], [2,3])
+        False
+
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:04:50Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([1], [1,2])
+        True
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:05:01Z

src/sage/combinat/set_partition.py

+        sage: compare_subsets([1,2], [1])
+        False
+
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:05:12Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([1,3,5], [1,3])
+        False
+        sage: from sage.combinat.set_partition import compare_subsets


Suggested change

sage: from sage.combinat.set_partition import compare_subsets

mantepse · 2025-06-28T09:05:36Z

src/sage/combinat/set_partition.py

+        sage: from sage.combinat.set_partition import compare_subsets
+        sage: compare_subsets([1, 3], [1, 3, 5])
+        True
+


Suggested change

mantepse · 2025-06-28T09:06:01Z

src/sage/combinat/set_partition.py

+
+    ::
+
+        sage: from sage.combinat.set_partition import SetPartition, compare_set_partitions


Suggested change

sage: from sage.combinat.set_partition import SetPartition, compare_set_partitions

mantepse · 2025-06-28T09:07:18Z

src/sage/combinat/set_partition.py

+
+    UNIT TESTS:
+
+    ::


Suggested change

UNIT TESTS:

::

mantepse · 2025-06-28T09:08:26Z

src/sage/combinat/set_partition.py

+    Compare a sequence of set partitions to ensure each partition is less than or equal to the next:
+
+    ::
+
+        sage: from sage.combinat.set_partition import SetPartitions, compare_set_partitions


Suggested change

Compare a sequence of set partitions to ensure each partition is less than or equal to the next:

::

sage: from sage.combinat.set_partition import SetPartitions, compare_set_partitions

Compare a sequence of set partitions to ensure each partition is less than or equal to the next::

sage: from sage.combinat.set_partition import compare_set_partitions

mantepse · 2025-06-28T09:08:48Z

src/sage/combinat/set_partition.py

+
+    ::


Suggested change

::

mantepse · 2025-06-28T09:09:17Z

src/sage/combinat/set_partition.py

+    :
+        sage: from sage.combinat.set_partition import SetPartition, compare_set_partitions


Suggested change

:

sage: from sage.combinat.set_partition import SetPartition, compare_set_partitions

mantepse · 2025-06-28T09:11:01Z

src/sage/combinat/set_partition.py

+    We create a list of set partitions of the set {1, 2, 3, 4, 5} into 3 parts, sort them, and check that each partition is lexicographically less than or equal to the next. This confirms that `compare_set_partitions` correctly identifies the lexicographic ordering among a sorted list of set partitions:
+
+    ::
+
+        sage: from sage.combinat.set_partition import SetPartitions, compare_set_partitions


Suggested change

We create a list of set partitions of the set {1, 2, 3, 4, 5} into 3 parts, sort them, and check that each partition is lexicographically less than or equal to the next. This confirms that `compare_set_partitions` correctly identifies the lexicographic ordering among a sorted list of set partitions:

::

sage: from sage.combinat.set_partition import SetPartitions, compare_set_partitions

We create a list of set partitions of the set {1, 2, 3, 4, 5}

into 3 parts, sort them, and check that each partition is

lexicographically less than or equal to the next. This

confirms that `compare_set_partitions` correctly identifies the

lexicographic ordering among a sorted list of set partitions::

mantepse · 2025-06-28T09:11:24Z

src/sage/combinat/set_partition.py

+        sage: j = SetPartition([ [1] ])
+        sage: compare_set_partitions(i, j)
+        True
+


Suggested change

mantepse · 2025-06-28T09:12:40Z

src/sage/combinat/set_partition.py

+
+    UNITS TESTS:
+
+        assert unranking(0, 0, 0) == [[]]
+
+        assert unranking(1, 1, 0) == [[1]]
+
+        assert unranking(3, 1, 0) == [[1, 2, 3]]
+
+        assert unranking(3, 3, 0) == [[1], [2], [3]]
+


Suggested change

UNITS TESTS:

assert unranking(0, 0, 0) == [[]]

assert unranking(1, 1, 0) == [[1]]

assert unranking(3, 1, 0) == [[1, 2, 3]]

assert unranking(3, 3, 0) == [[1], [2], [3]]

sage: unranking(0, 0, 0) == [[]]

True

sage: unranking(1, 1, 0) == [[1]]

True

sage: unranking(3, 1, 0) == [[1, 2, 3]]

True

sage: unranking(3, 3, 0) == [[1], [2], [3]]

True

mantepse · 2025-06-28T09:15:35Z

Why do you introduce compare_subsets, it is not used anywhere except in the tests, is it?

hugo-a-04 · 2025-06-30T08:28:29Z

Why do you introduce compare_subsets, it is not used anywhere except in the tests, is it?

This function was part of the project. Since it has potential future use, I decided to keep it rather than remove it.

fchapoton · 2025-06-30T08:51:36Z

Did you intend to close the pull request ? If not, you can re-open.

hugo-a-04 · 2025-06-30T09:04:17Z

Did you intend to close the pull request ? If not, you can re-open.

Thanks for the help. I'll do this

src/sage/combinat/set_partition.py

Co-authored-by: Martin Rubey <axiomize@yahoo.de>

fchapoton · 2025-07-01T19:02:51Z

src/sage/combinat/set_partition.py

+    from collections import defaultdict
+
+    @cached_method
+    def stilde(n: int, k: int, d: int) -> int:


you need to add the import of ZZ on top of the file ; note also that your type annotations are not correct, as sage Integers are not Python ints.

hugo-a-04 added 16 commits June 17, 2025 15:45

Fonctions supprimées : sequential_form, canonical_form, canonical_to_…

118cc1e

…sequential_form, sequential_to_canonical_form

Modification compare_substets : ajout cas a = []

8b5a509

Ajout tests sage pour compare_subsets

acd750e

Correction fonction compare_set_partitions : ajout cas a = SetPartiti…

236f8ea

…on([])

Ajouts tests unitaires sage pour compare_set_partitions

a732d43

Ajout commentaire input output pour unranked

f966010

Ajout test unitaires pour unranking

c823b4c

Ajout du raise pour le cas où r >= striling2(n,k)

c4efee2

Ajout crédits étu et article CurielGenitrini unranking, mini modif in…

62bb777

…put unranking

Replace set_partition.py by the original sage file (Because older ver…

8e123e6

…sion wasn't update)

Add the function : 'compare_subsets' and its tests

2a544a0

Add the function : 'compare_set_partitions' and its tests

91d43cd

Add the function : 'unranking' and its tests

0661a47

Add the import of the cached method

5e88e81

Add the credits

8985970

Merge branch 'develop' into develop

d0b03ad

fchapoton reviewed Jun 27, 2025

View reviewed changes

github-actions bot added the s: needs review label Jun 27, 2025

mantepse reviewed Jun 28, 2025

View reviewed changes

src/sage/combinat/set_partition.py Outdated Show resolved Hide resolved

mantepse reviewed Jun 28, 2025

View reviewed changes

src/sage/combinat/set_partition.py Outdated

Comment on lines 3475 to 3478

UNIT TESTS:

::

Copy link

Contributor

mantepse Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

UNIT TESTS:

::

mantepse reviewed Jun 28, 2025

View reviewed changes

src/sage/combinat/set_partition.py Outdated

Comment on lines 3448 to 3449

::

Copy link

Contributor

mantepse Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

::

mantepse reviewed Jun 28, 2025

View reviewed changes

hugo-a-04 closed this Jun 30, 2025

github-actions bot removed the s: needs review label Jun 30, 2025

Add PR sagemath#40318 suggestions

fac853e

hugo-a-04 mentioned this pull request Jun 30, 2025

Add Curiel–Genitrini unranking algorithm #40340

Closed

hugo-a-04 reopened this Jun 30, 2025

github-actions bot added the s: needs review label Jun 30, 2025

mantepse reviewed Jun 30, 2025

View reviewed changes

src/sage/combinat/set_partition.py Outdated Show resolved Hide resolved

Update src/sage/combinat/set_partition.py

02a47cc

Co-authored-by: Martin Rubey <axiomize@yahoo.de>

fchapoton reviewed Jul 1, 2025

View reviewed changes


		::

		sage: from sage.combinat.set_partition import SetPartition, compare_set_partitions

Uh oh!

Add Curiel–Genitrini unranking algorithm #40318

Are you sure you want to change the base?

Add Curiel–Genitrini unranking algorithm #40318

Uh oh!

Conversation

hugo-a-04 commented Jun 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mantepse commented Jun 28, 2025

Uh oh!

hugo-a-04 commented Jun 30, 2025

Uh oh!

fchapoton commented Jun 30, 2025

Uh oh!

hugo-a-04 commented Jun 30, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025 •

edited

Loading