intrinsic-test: combine files for better performance
#1856
+733
−581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
intrinsic-combine-files
branch
4 times, most recently
from
5597116 to
a555b87
Compare
folkertdev
force-pushed
the
intrinsic-combine-files
branch
from
a555b87 to
85aa7af
Compare
folkertdev
force-pushed
the
intrinsic-combine-files
branch
from
db5c9b5 to
3fceb9e
Compare
|
So we're down from 28 minutes to just 8 here for Now to get this broken up into something that isn't torture to review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the C and rust files into a file per thread. Especially for C this appears to skip a lot of work. Let's see how that works out in practice.