-
Notifications
You must be signed in to change notification settings - Fork 13.5k
update issue number for const_trait_impl
#143875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer This PR modifies cc @jieyouxu |
☔ The latest upstream changes (presumably #143867) made this pull request unmergeable. Please resolve the merge conflicts. |
Cc @oli-obk I concur with what @clarfonthey wrote
But everything that's not such a fundamental trait should get its own tracking issue. Those can be large, e.g. we have |
ff4ad24
to
77b6f1e
Compare
I moved |
This comment has been minimized.
This comment has been minimized.
77b6f1e
to
6b02597
Compare
I think it's probably reasonable to give the @bors r+ rollup |
My reasoning for saying that |
Frankly, I don't understand this logic at all. The operation of the
I don't see anything special or fundamentally interesting here. The methods of const traits are just ZST fn items that behave analogously to methods in non-const contexts. They don't really work that specially; all they have is an additional But again I have no idea what this has to do with feature gates. Splitting out the (edit:) That being said, I don't see any reason why we wouldn't want to stabilize a |
…t, r=compiler-errors update issue number for `const_trait_impl` r? project-const-traits cc rust-lang#67792 rust-lang#143874
Rollup of 16 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143592 (UWP: link ntdll functions using raw-dylib) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143710 (Updates to random number generation APIs) - #143724 (Tidy cleanup) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143893 (Don't require `eh_personality` lang item on targets that have a personality) Failed merges: - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143891 (Port `#[coverage]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup
r? project-const-traits
cc #67792 #143874