Guarantee 8 bytes of alignment in Thread::into_raw #143859
Open
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
AtomicPtr
for synchronization it's incredibly useful when you've got a couple bits you can stuff metadata in. By guaranteeing thatThread
'sInner
struct is aligned to 8 bytes everyone can use the bottom 3 bits to signal other things, such as a critical section, etc.This guarantee is thus very useful and costs us nothing.