bootstrap.py: add lockfile #143854
Open
bootstrap.py: add lockfile #143854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
bootstrap-py-lock-143756
branch
from
f033e32 to
9d46820
Compare
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
bootstrap-py-lock-143756
branch
from
9d46820 to
4ac0afb
Compare
the rust part of bootstrap already has a lockfile, but that's not good enough, the python side also shouldn't race with itself. fixes RUST-143756
lolbinarycat
force-pushed
the
bootstrap-py-lock-143756
branch
from
4ac0afb to
1c6986f
Compare
| run(args, env=env, verbose=build.verbose, is_bootstrap=True) | ||
| finally: | ||
| # always remove the lockfile | ||
| os.remove(lock_path) |
There was a problem hiding this comment.
Could we remove the lockfile earlier? It feels a bit odd to remove it only after (IIUC) we run the Rust part -- then the Rust lockfile is never considered, right? And the Rust part has far more extensive code (e.g., we print the PID and such, IIRC)...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rust part of bootstrap already has a lockfile, but that's not good enough,
the python side also shouldn't race with itself.
fixes #143756