Ports #[macro_use] and #[macro_escape] to the new attribute parsing infrastructure
#143843
Conversation
…trVisitor Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
…ng infrastructure Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in src/tools/clippy cc @rust-lang/clippy These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in compiler/rustc_attr_data_structures |
rustbot
added
the
S-blocked
| @@ -84,7 +85,7 @@ pub(crate) trait AttributeParser<S: Stage>: Default + 'static { | |||
| /// that'd be equivalent to unconditionally applying an attribute to | |||
| /// every single syntax item that could have attributes applied to it. | |||
| /// Your accept mappings should determine whether this returns something. | |||
| fn finalize(self, cx: &FinalizeContext<'_, '_, S>) -> Option<AttributeKind>; | |||
| fn finalize(self, cx: &mut FinalizeContext<'_, '_, S>) -> Option<AttributeKind>; | |||
There was a problem hiding this comment.
I've changed this to a mutable reference because I need a mutable reference to produce errors.
I'm assuming it not being mutable was just a mistake
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
macro-use-parser
branch
from
ebd4ed8 to
9680ee6
Compare
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
JonathanBrouwer
force-pushed
the
macro-use-parser
branch
from
9680ee6 to
874fe3b
Compare
Ports
#[macro_use]and#[macro_escape]to the new attribute parsing infrastructure for #131229 (comment)r? @jdonszelmann @oli-obk
Currently blocked on #143796, is in the merge queue right now should be fixed soon
@rustbot blocked