Tidy cleanup #143724
Tidy cleanup #143724
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-tidy
|
There are changes to the cc @jieyouxu The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
tidy-cleanup
branch
from
542dd67 to
97473a1
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
tidy-cleanup
branch
from
97473a1 to
c4b228c
Compare
src/tools/tidy/src/features.rs
Outdated
| // NB: the `splitn` always succeeds, even if the delimiter is not present. | ||
| Some(i) => line[i + gate_test_str.len()..].splitn(2, ' ').next().unwrap(), | ||
| Some(i) => line[i + gate_test_str.len()..].split(' ').next().unwrap(), |
There was a problem hiding this comment.
In this case it better use split_once? and fix comment.
There was a problem hiding this comment.
split_once will return None if the delimiter is not present, but split returns the whole string. I fixed the comment though.
| @@ -27,14 +29,13 @@ pub fn check(root_path: &Path, compiler_path: &Path, bad: &mut bool) { | |||
| // e607be166673a8de9fc07f6f02c60426e556c5f2 src/gcc (master-e607be166673a8de9fc07f6f02c60426e556c5f2.e607be) | |||
| // +e607be166673a8de9fc07f6f02c60426e556c5f2 src/gcc (master-e607be166673a8de9fc07f6f02c60426e556c5f2.e607be) | |||
| let git_output = String::from_utf8_lossy(&git_output.stdout) | |||
| .trim() | |||
There was a problem hiding this comment.
|
☔ The latest upstream changes (presumably #143721) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-cloud-vms
bot
force-pushed
the
tidy-cleanup
branch
2 times, most recently
from
9eccfdd to
11c005e
Compare
rust-cloud-vms
bot
force-pushed
the
tidy-cleanup
branch
from
11c005e to
8bf88a2
Compare
|
|
No description provided.