-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Add armv7-unknown-linux-musleabihf host tools to CI #142538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
I know there's a command to run a particular CI runner, but a) I don't know the syntax, b) not sure if I have permissions to do it? |
Let's make sure you can do that: @bors2 delegate=try @alex Generally you edit your PR desc so it has try-job: And then @ bors2 try See rust/src/ci/citool/src/main.rs Lines 55 to 63 in e314b97
|
@alex can now perform try builds on this pull request |
@bors2 try |
Add armv7-unknown-linux-musleabihf host tools to CI Related to rust-lang/rustup#3398 try-job: `dist-armv7-linux-musl`
💔 Test failed
|
0f7f1ba
to
9307946
Compare
@bors2 try |
Add armv7-unknown-linux-musleabihf host tools to CI Related to rust-lang/rustup#3398 try-job: `dist-armv7-linux-musl`
9307946
to
b42987a
Compare
I think this needs to follow the process for promoting to tier 2 with host tools - https://doc.rust-lang.org/beta/rustc/target-tier-policy.html#tier-2-with-host-tools, are you preparing that elsewhere? Config here seems OK, though it should probably be removing the tier 2 build from the dist-various builder? @rustbot author |
Sure, I'm happy to fill out an MCP for this -- is there by chance a previous one you know of that I can use as a reference on the format/level of detail that's expected? |
b42987a
to
af713a3
Compare
@bors2 try |
Add armv7-unknown-linux-musleabihf host tools to CI Related to rust-lang/rustup#3398 try-job: `dist-armv7-linux-musl` try-job: `dist-various`
You'd want to find the previous (if one exists) proposal for this target and copy/paste the target policy, filling out any item with details since the last uplift (to tier 2, if that one exists). rust-lang/compiler-team#864 is a tier 2 uplift but is broadly the right shape. |
💔 Test failed
|
@bors2 try |
Add armv7-unknown-linux-musleabihf host tools to CI Related to rust-lang/rustup#3398 try-job: `dist-armv7-linux-musl` try-job: `dist-various-1`
Proposed at rust-lang/compiler-team#888, thanks for the guidance. |
Related to rust-lang/rustup#3398
try-job:
dist-armv7-linux-musl
try-job:
dist-various-1